-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dropdown] hideAdditions should be false by default #4052
Comments
I'm having this same issue since upgrading from SUI 2.1 to 2.2.1. Sorry I don't have any solutions as yet. To clarify my problem: Important: A new label does indeed get created and added after user hits enter. So I guess technically allowAdditions is working, though the UX is a little off. @jlukic is there a known issue with 2.2.1 selection dropdown allowAdditions UX? |
Broken for me also. Reproduced in the dropdown demos (http://semantic-ui.com/modules/dropdown.html#tagging-and-user-additions). Chrome 51.0.2704.106 m. |
Looks like the change was introduced in 6562429. I'm having trouble telling if it was on purpose or not. Previously you did not need to specify |
Same here! |
Thank you Swendrich, you saved me a lot of time! |
In case anyone else googles and finds this, the "search" class is required for |
@whymahyah not that I know of. There’s a PR #3432 that might make it into the next release, but it will take a while. Closing the issue as resolved. |
@Banandrew why is this resolved? @whymahyah question was unrelated to the original issue reported. As originally asked, was the change in behavoir a desired change or a mistake? |
@JakeAlmer I understand that the question was unrelated; it was resolved, because I thought it was a usage question. I don’t know if the change was a mistake, and Jack has his hands full currently—frankly, I don’t think it matters at this point. Would you prefer |
Makes more sense to have |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
i have a Dropdown with property allowAdditions but is not working, how do I fix this?
my code:
The text was updated successfully, but these errors were encountered: