Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Add .inverted variation #5276

Open
raptoria opened this issue Apr 14, 2017 · 12 comments
Open

[Dropdown] Add .inverted variation #5276

raptoria opened this issue Apr 14, 2017 · 12 comments
Milestone

Comments

@raptoria
Copy link

no dark style exists for vanilla dropdown.

@awgv awgv changed the title Dropdown missing inverted style [Dropdown] Add .inverted variation Apr 14, 2017
@awgv
Copy link
Member

awgv commented Aug 9, 2017

I spent this past week trying to figure it out, and tried various aesthetic combinations, ending up with this. I’ll use the overrides below to propose a proper PR as soon as I can, so if you’re not happy with how it turned out, now is a good time to talk about it.

@Mathwhiz Thanks for patience, copy the following and rebuild the framework:

@librarianmage
Copy link

librarianmage commented Aug 9, 2017 via email

@TheRealJimShady
Copy link

TheRealJimShady commented Aug 22, 2017

@Banandrew, Looks fantastic :) - I'm getting a problem - variable @trackInvertedBackground is undefined, I've checked and dropdown and menu are both set to default.

@awgv
Copy link
Member

awgv commented Aug 22, 2017

Hi @JSmith2412, could you please post a screenshot of the terminal output that you’re getting during the building process? The variable is global and should be available if you include the site component in the building process.

@TheRealJimShady
Copy link

TheRealJimShady commented Aug 23, 2017

Hi there - think I know why it's not working... I'm using the Meteor.JS package for Semantic UI, which hasn't been updated in some time... Some of the variables you've used don't appear in the plugin because they were only added in standard Semantic UI quite recently... I looked them up and added them but still no joy. I'm not getting any errors, the dropdown just isn't dropping down on click... I've left the files exactly as you had them, but added the following to site/globals/site.variables

/* PASTED FROM NEWER VERSION OF SEMANTIC UI, NOT NATIVE TO  METEOR PLUGIN. */

/*-------------------
    Scroll Bars
--------------------*/

/* Inverted */
@trackInvertedBackground: rgba(255, 255, 255, 0.1);
@thumbInvertedBackground: rgba(255, 255, 255, 0.25);
@thumbInvertedInactiveBackground: rgba(255, 255, 255, 0.15);
@thumbInvertedHoverBackground: rgba(255, 255, 255, 0.35);

@TheRealJimShady
Copy link

Nailed it :) The non-dropping down was my fault, the menu wasn't being initialised properly (d'oh!). So there we go, for people using the Meteor JS Semantic UI plugin, you can go ahead and paste those variable definitions and it should work... Thank you @Banandrew !

@stale
Copy link

stale bot commented Feb 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 23, 2018
@librarianmage
Copy link

librarianmage commented Feb 23, 2018 via email

@stale stale bot removed the stale label Feb 23, 2018
@awgv
Copy link
Member

awgv commented Feb 23, 2018

@Mathwhiz Hi, I moved to other issues in August, and ended up not opening a proper PR for it. Unfortunately, I won’t be able to work on SUI for quite a while to do it.

@librarianmage
Copy link

librarianmage commented Feb 24, 2018 via email

@awgv
Copy link
Member

awgv commented Feb 24, 2018

@Mathwhiz Of course, I'd be thankful if someone did it properly, and you didn't even need to ask.

@y0hami y0hami added this to the 2.3.x milestone Mar 20, 2018
y0hami pushed a commit to y0hami/Semantic-UI that referenced this issue Mar 21, 2018
@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants