-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dropdown] Add .inverted
variation
#5276
Comments
.inverted
variation
I spent this past week trying to figure it out, and tried various aesthetic combinations, ending up with this. I’ll use the overrides below to propose a proper PR as soon as I can, so if you’re not happy with how it turned out, now is a good time to talk about it. @Mathwhiz Thanks for patience, copy the following and rebuild the framework: |
Awesome, thanks!
…On Tue, Aug 8, 2017 at 8:53 PM Andrew Golubev ***@***.***> wrote:
I spent this past week trying to figure it out, and tried various
aesthetic combinations, ending up with this
<https://jsfiddle.net/1ckq2n4b/embedded/result/>. I’ll use the overrides
below to propose a proper PR as soon as I can, so if you’re not happy with
how it turned out, now is a good time to talk about it.
@Mathwhiz <https://github.com/mathwhiz> Thanks for patience, copy the
following and rebuild the framework:
-
installation_folder/src/site/modules/dropdown.overrides
<https://drive.google.com/file/d/0B4i4WJu2r-_MQThOM0pad1dpNzQ/view?usp=sharing>
-
installation_folder/src/site/modules/dropdown.variables
<https://drive.google.com/file/d/0B4i4WJu2r-_MM29jdC1KYzJKbE0/view?usp=sharing>
-
installation_folder/src/site/collections/menu.overrides
<https://drive.google.com/file/d/0B4i4WJu2r-_MeDY3eUdHS1F4Nms/view?usp=sharing>
-
installation_folder/src/site/collections/menu.variables
<https://drive.google.com/file/d/0B4i4WJu2r-_McE1pN3ZhNjBNczA/view?usp=sharing>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5276 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALz_82CFEUkx9v1XBtDjpUjTZLt84a_Vks5sWREEgaJpZM4M9YtQ>
.
|
@Banandrew, Looks fantastic :) - I'm getting a problem - |
Hi @JSmith2412, could you please post a screenshot of the terminal output that you’re getting during the building process? The variable is global and should be available if you include the site component in the building process. |
Hi there - think I know why it's not working... I'm using the Meteor.JS package for Semantic UI, which hasn't been updated in some time... Some of the variables you've used don't appear in the plugin because they were only added in standard Semantic UI quite recently... I looked them up and added them but still no joy. I'm not getting any errors, the dropdown just isn't dropping down on click... I've left the files exactly as you had them, but added the following to
|
Nailed it :) The non-dropping down was my fault, the menu wasn't being initialised properly (d'oh!). So there we go, for people using the Meteor JS Semantic UI plugin, you can go ahead and paste those variable definitions and it should work... Thank you @Banandrew ! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
@Banandrew Have you made any progress with this?
…On Fri, Feb 23, 2018 at 1:54 AM stale[bot] ***@***.***> wrote:
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed in 30 days if no further activity
occurs. Thank you for your contributions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5276 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALz_83x5v08FNdoWwDoLlof67zKItLnLks5tXm6lgaJpZM4M9YtQ>
.
|
@Mathwhiz Hi, I moved to other issues in August, and ended up not opening a proper PR for it. Unfortunately, I won’t be able to work on SUI for quite a while to do it. |
Darn. Would it be okay if I submit your current changes as a PR?
…On Fri, Feb 23, 2018 at 5:35 PM Andrew Golubev ***@***.***> wrote:
@Mathwhiz <https://github.com/mathwhiz> Hi, I moved to other issues in
August, and ended up not opening a proper PR for it. Unfortunately, I won’t
be able to work on SUI for quite a while to do it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5276 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALz_826Ml2FYA9T5haEi_1xUOI8BBau9ks5tX0skgaJpZM4M9YtQ>
.
|
@Mathwhiz Of course, I'd be thankful if someone did it properly, and you didn't even need to ask. |
no dark style exists for vanilla dropdown.
The text was updated successfully, but these errors were encountered: