Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callback on correct timing #3405

Merged
merged 1 commit into from
Dec 19, 2015
Merged

Conversation

youngjay
Copy link
Contributor

fix build-css task callback timing

@jlukic
Copy link
Member

jlukic commented Nov 30, 2015

I'll check this out

Specifically what task are you importing that is causing issues?

@jlukic jlukic added this to the 2.2 milestone Nov 30, 2015
@youngjay
Copy link
Contributor Author

youngjay commented Dec 1, 2015

gulp.task('copy:semantic-to-dist', function() {
    return gulp.src('./semantic/dist/**/*').pipe(gulp.dest('./dist/semantic'));
});

gulp.task('build', function(done) {
    runSequence(
        'build-ui',
        'copy:semantic-to-dist',
        done
    );
});

The dist folder would not contain semantic.css and semantic.min.css after the build task completed.

jlukic added a commit that referenced this pull request Dec 19, 2015
@jlukic jlukic merged commit 7f2384c into Semantic-Org:next Dec 19, 2015
@jlukic
Copy link
Member

jlukic commented Dec 19, 2015

I think this is a fine solution. Thanks

@jlukic jlukic modified the milestones: 2.1.7, 2.2 Dec 19, 2015
jlukic added a commit that referenced this pull request Dec 19, 2015
jlukic added a commit that referenced this pull request Dec 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants