extend modal 'closable' option #262 #3625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to specify the exact closable behavior of a modal you can now set closable to ```click``` to allow closing nnly by clicking on the dimmer or you can set it to ```escapeKey``` to allow closing only by pressing the escape key.
|
+1 |
|
Makes sense, i'd reverse the logic in the PR though. |
|
This PR conflicts with #3396, I'd suggest merging that one first and then applying the logic for escape/click. |
|
👍 not sure why I chose inverted logic 😄 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to specify the exact closable behavior of a modal you can now set closable to
clickto allow closing only by clicking on the dimmer or you can set it toescapeKeyto allow closing only by pressing the escape key.