Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Material Design Icons to Semantic UI material theme. #4412

Merged
merged 3 commits into from
Aug 22, 2016
Merged

Added Material Design Icons to Semantic UI material theme. #4412

merged 3 commits into from
Aug 22, 2016

Conversation

nielslerche
Copy link
Contributor

No description provided.

@jlukic
Copy link
Member

jlukic commented Aug 11, 2016

Merged in 49444b6 I've modified paths to be more consistent with rest of lib

@jlukic jlukic merged commit 4fc9f00 into Semantic-Org:master Aug 22, 2016
@3zzy
Copy link

3zzy commented Sep 15, 2016

Awesome! How do I use material icons instead of FontAwesome? The documentation doesn't say anything about it.

@nielslerche
Copy link
Contributor Author

If you have the material theme for Semantic UI installed, you should be able to change the @icon property value to material in the theme config.

ali1k added a commit to slidewiki/custom-semantic-ui that referenced this pull request Oct 14, 2016
* 'master' of https://github.com/Semantic-Org/Semantic-UI: (62 commits)
  Fix fg-color on inverted forms in Flat theme.
  Add transition fallback to progress
  Rebuild 2.2.4
  Semantic-Org#4463 - remove bad dep
  Build 2.2.4
  Fixes missing message var
  Revert "zone.js/issues/319 Loosen equality on undefined check for determining input event"
  Fix typos in rlsnotes 2.2.3
  Finalize release notes 2.2.3
  Build 2.2.3
  Semantic-Org#4284 - Fixes obvious brand colors.. tbd instagram
  Add iconPath duplication to avoid reqing material site theme
  Semantic-Org#4412, redo paths to be more consistent with default theme
  Rlsnotes Semantic-Org#4399
  Semantic-Org#4403 cred
  Semantic-Org#4408 - adds cred
  Fixes comment sizing Semantic-Org#4408
  Fix point-events typo Semantic-Org#4408
  Update icon.variables
  Corrected for missing <i> selector
  ...
@neekey
Copy link

neekey commented Dec 4, 2016

Hi, I noticed that there is not a .woff2 font file included in this theme, according to the source code for Icon https://github.com/Semantic-Org/Semantic-UI/blob/master/src/themes/default/elements/icon.variables#L13, 5 type of font files should always be presented, and this will cause build error when I tried to build it with webpack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants