Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build Tools] Meteor package: Use api.addAssets for static files #6790

Merged
merged 2 commits into from
May 26, 2020

Conversation

gimco
Copy link
Contributor

@gimco gimco commented Apr 15, 2019

Description

Trying add the semantic-ui package to a meteor project raise the next error:

$ meteor add semantic:ui-css

 => Errors while adding packages:             
                                              
While building package semantic:ui-css:
error: No plugin known to handle file 'themes/default/assets/fonts/icons.eot'. If you want this file to be a static asset, use addAssets instead of addFiles; eg,
api.addAssets('themes/default/assets/fonts/icons.eot', 'client').
error: No plugin known to handle file 'themes/default/assets/fonts/icons.svg'. If you want this file to be a static asset, use addAssets instead of addFiles; eg,
api.addAssets('themes/default/assets/fonts/icons.svg', 'client').
error: No plugin known to handle file 'themes/default/assets/fonts/icons.ttf'. If you want this file to be a static asset, use addAssets instead of addFiles; eg,
api.addAssets('themes/default/assets/fonts/icons.ttf', 'client').
error: No plugin known to handle file 'themes/default/assets/fonts/icons.woff'. If you want this file to be a static asset, use addAssets instead of addFiles; eg,
api.addAssets('themes/default/assets/fonts/icons.woff', 'client').
error: No plugin known to handle file 'themes/default/assets/fonts/icons.woff2'. If you want this file to be a static asset, use addAssets instead of addFiles; eg,
api.addAssets('themes/default/assets/fonts/icons.woff2', 'client').
error: No plugin known to handle file 'themes/default/assets/images/flags.png'. If you want this file to be a static asset, use addAssets instead of addFiles; eg,
api.addAssets('themes/default/assets/images/flags.png', 'client').

Since meteor 1.2 api.addAsset should be used to define static files. So this pull request simple use addAsset for static files and addFiles to files whose must be processed by the framework.

Related Issues

Semantic-Org/Semantic-UI-CSS#14
Semantic-Org/Semantic-UI-CSS#18
Semantic-Org/UI-Flag#1
Semantic-Org/UI-Icon#5

Since meteor 1.2 addAsset should be used to define static files.
@jlukic
Copy link
Member

jlukic commented May 26, 2020

This looks good to me. Sorry about the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants