-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pickers react #103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #103 +/- ##
===========================================
- Coverage 87.15% 86.17% -0.99%
===========================================
Files 106 109 +3
Lines 3129 3189 +60
Branches 737 757 +20
===========================================
+ Hits 2727 2748 +21
- Misses 402 441 +39
Continue to review full report at Codecov.
|
gallayl
suggested changes
Feb 7, 2019
removed actionClickHandler
Merged Item type with ItemComponentProps
Removed backlink from picker base Used listpicker in pathpicker
herflis
reviewed
Feb 13, 2019
herflis
approved these changes
Feb 13, 2019
removed duplicate guard for parent selection
herflis
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pickers react package with list picker component