redundant type definition cleanup

examples/sn-dms-demo/src/Actions.ts

@@ -146,9 +146,7 @@ export const trackUploadProgress = async <T extends GenericContent>(
   dispatch: Dispatch,
   api: Repository,
 ) => {
-  let currentUpload: ExtendedUploadProgressInfo | undefined = getState().dms.uploads.uploads.find(
-    u => u.guid === currentValue.guid,
-  )
+  let currentUpload = getState().dms.uploads.uploads.find(u => u.guid === currentValue.guid)
   if (currentUpload) {
     dispatch(updateUploadItem(currentValue))
   } else {

examples/sn-dms-demo/src/Reducers.ts

@@ -29,15 +29,15 @@ export const email: Reducer<string, Action & { email?: string }> = (state = '',
       return state
   }
 }
-export const registrationError: Reducer<string | null, Action> = (state: string | null = null, action: AnyAction) => {
+export const registrationError: Reducer<string | null, Action> = (state = null, action: AnyAction) => {
   switch (action.type) {
     case 'USER_REGISTRATION_FAILURE':
       return resources.USER_IS_ALREADY_REGISTERED
     default:
       return state
   }
 }
-export const isRegistering: Reducer<boolean> = (state: boolean = false, action: AnyAction) => {
+export const isRegistering: Reducer<boolean> = (state = false, action: AnyAction) => {
   switch (action.type) {
     case 'USER_REGISTRATION_REQUEST':
       return true
@@ -49,7 +49,7 @@ export const isRegistering: Reducer<boolean> = (state: boolean = false, action:
   }
 }
 
-export const registrationDone: Reducer<boolean> = (state: boolean = false, action: AnyAction) => {
+export const registrationDone: Reducer<boolean> = (state = false, action: AnyAction) => {
   switch (action.type) {
     case 'USER_REGISTRATION_SUCCESS':
       return true
@@ -62,7 +62,7 @@ export const registrationDone: Reducer<boolean> = (state: boolean = false, actio
   }
 }
 
-export const captcha: Reducer<boolean> = (state: boolean = false, action: AnyAction) => {
+export const captcha: Reducer<boolean> = (state = false, action: AnyAction) => {
   switch (action.type) {
     case 'VERIFY_CAPTCHA_SUCCESS':
       return true
@@ -79,7 +79,7 @@ export const register = combineReducers({
   captcha,
 })
 
-export const open: Reducer<boolean> = (state: boolean = false, action: AnyAction) => {
+export const open: Reducer<boolean> = (state = false, action: AnyAction) => {
   switch (action.type) {
     case 'OPEN_ACTIONMENU':
       return true
@@ -90,7 +90,7 @@ export const open: Reducer<boolean> = (state: boolean = false, action: AnyAction
   }
 }
 
-export const actions: Reducer<ActionModel[]> = (state: ActionModel[] = [], action: AnyAction) => {
+export const actions: Reducer<ActionModel[]> = (state = [], action: AnyAction) => {
   switch (action.type) {
     case 'LOAD_CONTENT_ACTIONS_SUCCESS':
       const result: { d: { Actions: ActionModel[] } } = (action.result as Actions.PromiseReturns<
@@ -104,7 +104,7 @@ export const actions: Reducer<ActionModel[]> = (state: ActionModel[] = [], actio
   }
 }
 
-export const id: Reducer<number | null> = (state: number | null = null, action: AnyAction) => {
+export const id: Reducer<number | null> = (state = null, action: AnyAction) => {
   switch (action.type) {
     case 'OPEN_ACTIONMENU':
       return action.id || null
@@ -248,7 +248,7 @@ export const isSelectionModeOn: Reducer<boolean> = (state = false, action: AnyAc
   }
 }
 
-export const userActions: Reducer<ActionModel[]> = (state: ActionModel[] = [], action: AnyAction) => {
+export const userActions: Reducer<ActionModel[]> = (state = [], action: AnyAction) => {
   switch (action.type) {
     case 'LOAD_USER_ACTIONS_SUCCESS':
       const result = action.result as Actions.PromiseReturns<typeof loadUserActions>
@@ -258,7 +258,7 @@ export const userActions: Reducer<ActionModel[]> = (state: ActionModel[] = [], a
   }
 }
 
-export const addNewTypes: Reducer<ActionModel[]> = (state: ActionModel[] = [], action: AnyAction) => {
+export const addNewTypes: Reducer<ActionModel[]> = (state = [], action: AnyAction) => {
   switch (action.type) {
     case 'LOAD_TYPES_TO_ADDNEW_LIST_SUCCESS':
       const result = action.result as Actions.PromiseReturns<typeof loadTypesToAddNewList>
@@ -268,7 +268,7 @@ export const addNewTypes: Reducer<ActionModel[]> = (state: ActionModel[] = [], a
   }
 }
 
-export const actionmenuContent: Reducer<GenericContent> = (state: GenericContent | null = null, action: AnyAction) => {
+export const actionmenuContent: Reducer<GenericContent | null> = (state = null, action: AnyAction) => {
   switch (action.type) {
     case 'OPEN_ACTIONMENU':
       return action.content
@@ -435,7 +435,7 @@ export const viewer: Reducer<{ isOpened: boolean; currentDocumentId: number }, A
   return state
 }
 
-export const isOpened: Reducer<boolean> = (state: boolean = false, action: AnyAction) => {
+export const isOpened: Reducer<boolean> = (state = false, action: AnyAction) => {
   switch (action.type) {
     case 'OPEN_DIALOG':
       return true
@@ -445,10 +445,7 @@ export const isOpened: Reducer<boolean> = (state: boolean = false, action: AnyAc
   return state
 }
 
-export const onClose: Reducer<() => void | undefined> = (
-  state: () => void | undefined = () => undefined,
-  action: AnyAction,
-) => {
+export const onClose: Reducer<() => void | undefined> = (state = () => undefined, action: AnyAction) => {
   switch (action.type) {
     case 'OPEN_DIALOG':
       return action.onClose
@@ -471,7 +468,7 @@ export const dialogContent: Reducer<React.Component | undefined> = (
   return state
 }
 
-export const dialogTitle: Reducer<string> = (state: string = '', action: AnyAction) => {
+export const dialogTitle: Reducer<string> = (state = '', action: AnyAction) => {
   switch (action.type) {
     case 'OPEN_DIALOG':
       return action.title
@@ -498,7 +495,7 @@ export const versions = (state: GenericContent[] = [], action: AnyAction) => {
   }
 }
 
-export const menuOpen: Reducer<boolean> = (state: boolean = false, action: AnyAction) => {
+export const menuOpen: Reducer<boolean> = (state = false, action: AnyAction) => {
   switch (action.type) {
     case 'HANDLE_DRAWERMENU':
       return action.open

examples/sn-dms-demo/src/ViewerSettings.ts

@@ -14,12 +14,12 @@ import { v1 } from 'uuid'
 /**
  * Adds a globally unique ID to the shape
  */
-const addGuidToShape: <T extends Shape>(shape: T) => T = shape => {
+const addGuidToShape = <T extends Shape>(shape: T) => {
   shape.guid = v1()
   return shape
 }
 
-export const getViewerSettings: (repo: Repository) => DocumentViewerSettings = (repo: Repository) =>
+export const getViewerSettings = (repo: Repository) =>
   new DocumentViewerSettings({
     saveChanges: async (documentData, pages) => {
       const reqBody = {
@@ -67,7 +67,7 @@ export const getViewerSettings: (repo: Repository) => DocumentViewerSettings = (
         pageAttributes: (documentData.PageAttributes && JSON.parse(documentData.PageAttributes)) || [],
       }
     },
-    isPreviewAvailable: async (documentData, version, page: number) => {
+    isPreviewAvailable: async (documentData, version, page) => {
       const responseBody = await repo.executeAction<{ page: number }, PreviewImageData & { PreviewAvailable: string }>({
         idOrPath: documentData.idOrPath,
         method: 'POST',

examples/sn-dms-demo/src/components/ActionMenu/AddNewMenu.tsx

@@ -120,7 +120,7 @@ class AddNewMenu extends React.Component<
       )
   }
   public render() {
-    return <AddNewButton contentType="" onClick={(e: React.MouseEvent<HTMLElement>) => this.handleButtonClick(e)} />
+    return <AddNewButton contentType="" onClick={e => this.handleButtonClick(e)} />
   }
 }
 

examples/sn-dms-demo/src/components/BreadCrumb.tsx

@@ -141,7 +141,7 @@ class BreadCrumb extends React.Component<
                         ) : (
                           <Icon
                             style={styles.breadCrumbIconLast}
-                            onClick={(e: React.MouseEvent<HTMLElement>) => this.handleActionMenuClick(e, ancestor)}
+                            onClick={e => this.handleActionMenuClick(e, ancestor)}
                             type={iconType.materialui}
                             iconName={icons.arrowDropDown}
                           />
@@ -150,7 +150,7 @@ class BreadCrumb extends React.Component<
                       {!isLast ? (
                         <Icon
                           style={styles.breadCrumbIcon}
-                          onClick={(e: React.MouseEvent<HTMLElement>) => this.handleActionMenuClick(e, ancestor)}
+                          onClick={e => this.handleActionMenuClick(e, ancestor)}
                           type={iconType.materialui}
                           iconName={icons.arrowRight}
                         />

examples/sn-dms-demo/src/components/Dialogs/VersionsDialog.tsx

@@ -240,7 +240,7 @@ class VersionsDialog extends React.Component<
                         </TableRow>
                       </TableHead>
                       <TableBody>
-                        {versions.map((version, index: number) => (
+                        {versions.map((version, index) => (
                           <TableRow key={index}>
                             <TableCell padding="checkbox" className={classes.versionNumber}>
                               {this.formatVersionNumber(version.Version || '')}
@@ -286,7 +286,7 @@ class VersionsDialog extends React.Component<
                 ) : (
                   <Paper>
                     <Typography style={styles.mobileVersionsTitle}>{resources.VERSIONS}</Typography>
-                    {versions.map((version, index: number) => (
+                    {versions.map((version, index) => (
                       <ExpansionPanel
                         style={styles.innerMobileList}
                         key={`panel${index}`}

examples/sn-dms-demo/src/components/MessageBar.tsx

@@ -82,7 +82,7 @@ class MessageBar extends React.Component<
       e.messageEntry && e.messageEntry.bulkMessage && e.messageEntry.bulkMessage
 
     const grouped = groupBy(newProps.entries.filter(e => e.messageEntry), getBulkMessageKey)
-    const msgSegments: MessageBarState['digestedMessageEntries'] = [...lastState.digestedMessageEntries]
+    const msgSegments = [...lastState.digestedMessageEntries]
     for (const type in grouped) {
       if (grouped[type]) {
         const groupedEntries = grouped[type]

examples/sn-dms-demo/src/components/Pickers/PathPicker.tsx

@@ -192,7 +192,7 @@ class PathPicker extends React.Component<
                         type={iconType.materialui}
                         iconName="keyboard_arrow_right"
                         style={this.isHovered ? styles.openIcon : { display: 'none' }}
-                        onClick={(e: React.MouseEvent<HTMLElement>) => this.handleClick(e, item)}
+                        onClick={e => this.handleClick(e, item)}
                       />
                     ) : null}
                   </MenuItem>

examples/sn-dms-demo/src/components/Upload/UploadButton.tsx

@@ -39,9 +39,9 @@ export interface UploadButtonState {
   anchorElement: HTMLElement | undefined
 }
 
-export const UPLOAD_FILE_BUTTON_ID: string = 'sn-dms-upload-button'
-export const UPLOAD_FOLDER_BUTTON_ID: string = 'sn-dms-upload-button'
-export const UPLOAD_MENU_ID: string = 'sn-dms-upload-button'
+export const UPLOAD_FILE_BUTTON_ID = 'sn-dms-upload-button'
+export const UPLOAD_FOLDER_BUTTON_ID = 'sn-dms-upload-button'
+export const UPLOAD_MENU_ID = 'sn-dms-upload-button'
 
 export class UploadButton extends React.Component<UploadButtonProps, UploadButtonState> {
   private readonly uploadFileButtonId = `${UPLOAD_FILE_BUTTON_ID}-${v1()}`

examples/sn-dms-demo/src/pages/Dashboard.tsx

@@ -160,6 +160,7 @@ class DashboardComponent extends React.Component<
                       <Switch>
                         <Route
                           path="/documents"
+                          // tslint:disable-next-line: no-unnecessary-type-annotation
                           component={(props: RouteComponentProps<any>) => (
                             <Switch>
                               <Route path={props.match.url + '/shared'}>
@@ -222,6 +223,7 @@ class DashboardComponent extends React.Component<
                     <Switch>
                       <Route
                         path="/documents"
+                        // tslint:disable-next-line: no-unnecessary-type-annotation
                         component={(props: RouteComponentProps<any>) => (
                           <Switch>
                             <Route path={props.match.url + '/shared'}>
@@ -248,6 +250,7 @@ class DashboardComponent extends React.Component<
                       />
                       <Route
                         path="/users"
+                        // tslint:disable-next-line: no-unnecessary-type-annotation
                         component={(props: RouteComponentProps<any>) => (
                           <Switch>
                             <Route

examples/sn-dms-demo/src/store/actionlog/actions.ts

@@ -6,7 +6,7 @@ import { IInjectableActionCallbackParams } from 'redux-di-middleware'
 import { resources } from '../../assets/resources'
 import { rootStateType } from '../../store/rootReducer'
 
-export const logActions: string[] = ['CheckIn', 'Checkout', 'UndoCheckOut', 'Approve', 'Reject', 'Publish']
+export const logActions = ['CheckIn', 'Checkout', 'UndoCheckOut', 'Approve', 'Reject', 'Publish']
 
 export interface MessageEntry {
   verbosity: 'info' | 'error'
@@ -37,6 +37,7 @@ export const readLogEntries = createAction((entries: LogEntry[]) => ({
 
 export const initLog = createAction(() => ({
   type: 'SN_DMS_INIT_LOG',
+  // tslint:disable-next-line: no-unnecessary-type-annotation
   inject: async (options: IInjectableActionCallbackParams<rootStateType>) => {
     const repository = options.getInjectable(Repository)
     const eventHub = new EventHub(repository)

examples/sn-dms-demo/src/store/documentlibrary/actions.ts

@@ -30,6 +30,7 @@ export const finishLoadingChildren = createAction(() => ({
 export const loadParent = createAction(
   <T extends GenericContent = GenericContent>(idOrPath: number | string, loadParentOptions?: ODataParams<T>) => ({
     type: 'DMS_DOCLIB_LOAD_PARENT',
+    // tslint:disable-next-line: no-unnecessary-type-annotation
     inject: async (options: IInjectableActionCallbackParams<rootStateType>) => {
       const prevState = options.getState().dms.documentLibrary
       if (prevState.parentIdOrPath === idOrPath) {
@@ -119,6 +120,7 @@ export const loadParent = createAction(
 
 export const loadMore = createAction((count: number = loadChunkSize) => ({
   type: 'DMS_DOCLIB_LOAD_MORE',
+  // tslint:disable-next-line: no-unnecessary-type-annotation
   inject: async (options: IInjectableActionCallbackParams<rootStateType>) => {
     const currentDocLibState = options.getState().dms.documentLibrary
 
@@ -187,6 +189,7 @@ export const setActive = createAction(<T extends GenericContent>(active?: T) =>
 export const updateChildrenOptions = createAction(<T extends GenericContent>(odataOptions: ODataParams<T>) => ({
   type: 'DMS_DOCLIB_UPDATE_CHILDREN_OPTIONS',
   odataOptions,
+  // tslint:disable-next-line: no-unnecessary-type-annotation
   inject: async (options: IInjectableActionCallbackParams<rootStateType>) => {
     const currentState = options.getState()
     const parentPath = currentState.dms.documentLibrary.parent ? currentState.dms.documentLibrary.parent.Path : ''

examples/sn-dms-demo/src/store/edited/reducers.ts

@@ -2,10 +2,7 @@ import { GenericContent } from '@sensenet/default-content-types'
 import { loadContent, PromiseReturns } from '@sensenet/redux/dist/Actions'
 import { AnyAction, Reducer } from 'redux'
 
-export const editedContent: Reducer<GenericContent | null> = (
-  state: GenericContent | null = null,
-  action: AnyAction,
-) => {
+export const editedContent: Reducer<GenericContent | null> = (state = null, action: AnyAction) => {
   switch (action.type) {
     case 'LOAD_EDITED_CONTENT_SUCCESS':
       return (action.result as PromiseReturns<typeof loadContent>).d