Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon rework #1252

Merged
merged 3 commits into from
Apr 13, 2021
Merged

Icon rework #1252

merged 3 commits into from
Apr 13, 2021

Conversation

taki9
Copy link
Contributor

@taki9 taki9 commented Mar 23, 2021

No description provided.

@taki9 taki9 self-assigned this Mar 23, 2021
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #1252 (8189132) into develop (c3211f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1252   +/-   ##
========================================
  Coverage    93.50%   93.50%           
========================================
  Files          232      232           
  Lines         6315     6315           
  Branches      1674     1674           
========================================
  Hits          5905     5905           
  Misses         410      410           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3211f4...8189132. Read the comment docs.

@sensenet
Copy link

sensenet bot commented Mar 23, 2021

Site name Url Last deploy
sn-app-dev https://6059ac1bd2b58eb3fe56c1b2--sn-app-dev.netlify.app Tue Mar 23 2021 - 08:51:41 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://6059ac124734d8b77e3ebc8a--sn-react-component-docs-dev.netlify.app Tue Mar 23 2021 - 08:51:31 GMT+0000 (Coordinated Universal Time)

Copy link
Contributor

@enikonemeth enikonemeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some icons what changed, but I think the old version was so much better, than the new.
Could you please replace these to the "old version"?
2021-03-25_09h12_01
2021-03-25_09h12_27
2021-03-25_09h16_05
2021-03-25_09h16_18

@herflis
Copy link
Contributor

herflis commented Mar 25, 2021

@pusztaienike the other pr's with the ctd icon changes are not merged yet, so these are not the final version of them :)

@enikonemeth
Copy link
Contributor

Trash is still not okay,
Under sample ws Links, Memos, Tasks are different than before
image
image

@enikonemeth enikonemeth self-requested a review April 13, 2021 07:20
@taki9 taki9 merged commit 63aed28 into develop Apr 13, 2021
@taki9 taki9 deleted the feature/icon-rework branch April 13, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants