Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrade #1299

Merged
merged 7 commits into from
May 5, 2021
Merged

Dependency upgrade #1299

merged 7 commits into from
May 5, 2021

Conversation

enikonemeth
Copy link
Contributor

@enikonemeth enikonemeth commented Apr 20, 2021

storybook had a wrong import :(

ReactMarkdown changed its props: https://github.com/remarkjs/react-markdown/blob/main/changelog.md
(source to children)

date-io is skipped as usual (material-ui date picker only work with the currently installed version)

react and react-dom cannot be updated to 17.x yet, we are waiting for http://github.com/enzymejs/enzyme/issues/2429 this issue. related PR: http://github.com/enzymejs/enzyme/pull/2430

webpack and ts-loader is not upgradable on sn-react-component-docs (storybook). No stable release currently support webpack 5.

@enikonemeth enikonemeth self-assigned this Apr 20, 2021
@sensenet
Copy link

sensenet bot commented Apr 20, 2021

Site name Url Last deploy
sn-app-dev https://609241eaf930bf901043193c--sn-app-dev.netlify.app Wed May 05 2021 - 06:57:48 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://609241ee2b63fb9297f98e0d--sn-react-component-docs-dev.netlify.app Wed May 05 2021 - 06:57:51 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #1299 (4d9b387) into develop (6af3d67) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1299   +/-   ##
========================================
  Coverage    93.50%   93.50%           
========================================
  Files          232      232           
  Lines         6317     6317           
  Branches      1676     1676           
========================================
  Hits          5907     5907           
  Misses         410      410           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af3d67...4d9b387. Read the comment docs.

@enikonemeth enikonemeth merged commit 6c018cd into develop May 5, 2021
@enikonemeth enikonemeth deleted the feature/dep_upgrade branch May 5, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants