Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook template icons #1311

Merged
merged 9 commits into from
May 5, 2021
Merged

Webhook template icons #1311

merged 9 commits into from
May 5, 2021

Conversation

herflis
Copy link
Contributor

@herflis herflis commented May 3, 2021

No description provided.

@herflis herflis requested review from taki9 and enikonemeth May 3, 2021 10:49
@sensenet
Copy link

sensenet bot commented May 3, 2021 •
edited
Loading

Site name Url Last deploy
sn-app-dev https://60929294cf07a11322f4bf3f--sn-app-dev.netlify.app Wed May 05 2021 - 12:41:57 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://6092929730978416ada530d2--sn-react-component-docs-dev.netlify.app Wed May 05 2021 - 12:42:00 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented May 3, 2021 •
edited
Loading

Codecov Report

Merging #1311 (aed7b04) into develop (3540fe4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1311   +/-   ##
========================================
  Coverage    93.50%   93.50%           
========================================
  Files          232      232           
  Lines         6317     6317           
  Branches      1676     1676           
========================================
  Hits          5907     5907           
  Misses         410      410

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3540fe4...aed7b04. Read the comment docs.

taki9
taki9 reviewed May 3, 2021
View reviewed changes
apps/sensenet/package.json Show resolved Hide resolved
apps/sensenet/src/components/AddButton.tsx Outdated Show resolved Hide resolved
@herflis herflis requested a review from taki9 May 4, 2021 13:35
enikonemeth
enikonemeth reviewed May 4, 2021
View reviewed changes
Copy link
Contributor

@enikonemeth enikonemeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it does not seems good: only gatsby has the right icon
image

This branch has also lint error and it seems that github cannot deploy storybook as well.
(I think it is related to yarn.lock upgrade ?!)

enikonemeth
enikonemeth approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@enikonemeth enikonemeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞

@herflis herflis merged commit 56c5190 into develop May 5, 2021
@herflis herflis deleted the feat/add-webhook-template-icons branch May 5, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enikonemeth enikonemeth enikonemeth approved these changes

@taki9 taki9 taki9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@herflis @taki9 @enikonemeth