Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all image previews in reference picker #1524

Merged
merged 16 commits into from
Sep 27, 2023

Conversation

VargaJoe
Copy link
Contributor

@VargaJoe VargaJoe commented Sep 1, 2023

No description provided.

@VargaJoe VargaJoe linked an issue Sep 1, 2023 that may be closed by this pull request
@sensenet
Copy link

sensenet bot commented Sep 1, 2023

Site name Url Last deploy
sn-react-component-docs-dev https://6513f430f1e8a9781bc319f9--sn-react-component-docs-dev.netlify.app Wed Sep 27 2023 - 09:21:53 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://6513f4506ede2a7d6461e68d--sn-app-dev.netlify.app Wed Sep 27 2023 - 09:22:26 GMT+0000 (Coordinated Universal Time)

@VargaJoe VargaJoe changed the title display referenced image Display all image previews in reference picker Sep 1, 2023
@hassanad94
Copy link
Contributor

Nagyon Extra lett a fejlesztés. Nagyon gyorsan szerintem jó megoldást választottál. :D

Átalakítottam egy picit.

Annak érdekében, hogy könnyen bővíthető legyen kiszedtem a ternary operator és if-vel illetve guard clauses-rel oldottam meg.( A logika maradt )

Volt benne egy typscript hiba. Azt is javítottam. (Elötted is ott volt)

Illetve ráraktam egy object fit: 'scale-down'-t a képre hogy eggyel jobban mutasson.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (29a5851) 92.51% compared to head (20052ac) 92.51%.

❗ Current head 20052ac differs from pull request most recent head c66d82e. Consider uploading reports for the commit c66d82e to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1524   +/-   ##
========================================
  Coverage    92.51%   92.51%           
========================================
  Files          250      250           
  Lines         7050     7050           
  Branches      1914     1914           
========================================
  Hits          6522     6522           
  Misses         528      528           
Files Coverage Δ
.../fieldcontrols/reference-grid/reference-picker.tsx 77.41% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VargaJoe VargaJoe marked this pull request as draft September 14, 2023 14:53
@VargaJoe VargaJoe marked this pull request as ready for review September 26, 2023 14:16
@VargaJoe VargaJoe merged commit 9c16a58 into develop Sep 27, 2023
5 checks passed
@VargaJoe VargaJoe deleted the Display-all-image-previews-in-reference-picker branch September 27, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display all image previews in reference picker
3 participants