Feature/theme switcher

[enikonemeth]

• Remove repository change from the usermenu
• Refactor to avoid/remove theme service

[sensenet]

Site name	Url	Last deploy
sn-react-component-docs-dev	https://5e1c73a483ae738f51a44298--sn-react-component-docs-dev.netlify.com	Mon Jan 13 2020 - 13:41:57 GMT+0000 (Coordinated Universal Time)
sn-app-dev	https://5e1c73dc1a247a7f4d72a647--sn-app-dev.netlify.com	Mon Jan 13 2020 - 13:42:54 GMT+0000 (Coordinated Universal Time)
sn-dms-demo-dev	https://5e1c739613dc8f68326f3c40--sn-dms-demo-dev.netlify.com	Mon Jan 13 2020 - 13:41:43 GMT+0000 (Coordinated Universal Time)

[codecov]

Codecov Report

Merging #525 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop     #525   +/-   ##
========================================
  Coverage    91.36%   91.36%           
========================================
  Files          192      192           
  Lines         5209     5209           
  Branches      1302     1302           
========================================
  Hits          4759     4759           
  Misses         450      450

Impacted Files	Coverage Δ
...ges/sn-controls-react/src/viewcontrols/NewView.tsx	96% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfef07c...e0ba9f9. Read the comment docs.

[zoltanbedi]

There is strange behavior when I change theme the drawer items gets reinitialized and there are multiple getActions request sent. Please check if you can avoid that.

[zoltanbedi]

One more thing I would love to see in this pr is

const prefersDarkMode = useMediaQuery('(prefers-color-scheme: dark)')

this code somewhere.
https://web.dev/prefers-color-scheme/
It would be awesome if we would support this bydesign. 😊
@herflis Are you okay with this?

[enikonemeth]

There is strange behavior when I change theme the drawer items gets reinitialized and there are multiple getActions request sent. Please check if you can avoid that.

In use-drawer-item we are watching the settings (line 168-189) variable
const settings = useContext(ResponsivePersonalSetttings)
when we get the actions for drawer items.

export const ResponsivePersonalSetttings = React.createContext(defaultSettings.default)
...
ResponsivePersonalSetttings.Provider value={deepMerge(personalSettings.default, personalSettings.desktop)}>

In ResponsiveContextProvider the personalSettings is reactive so when it changes it will effect that we should update the drawer items as well.

To avoid this, we can remove the settings variable from the watches list in use-drawer-items, but it will cause lint warning...

[enikonemeth]

One more thing I would love to see in this pr is

const prefersDarkMode = useMediaQuery('(prefers-color-scheme: dark)')

this code somewhere.
https://web.dev/prefers-color-scheme/
It would be awesome if we would support this bydesign. 😊
@herflis Are you okay with this?

In the original issue light theme was what I should use:

Another related issue is that maybe we could try out 'light' as the default theme, because not everyone was fascinated by the dark theme. 🕶

[zoltanbedi]

🌑