20210917 Mosquitto - HTTP not HTTPS during build + health check - experimental branch - PR 3 of 3 #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A problem affecting the build of the Mosquitto container keeps showing up in Discord questions. Examples: * [2021-09-17](https://discord.com/channels/638610460567928832/638610461109256194/888096248761045022) * [2021-09-09](https://discord.com/channels/638610460567928832/638610461109256194/885494986710335498) The problem is discussed in [alpinelinux/docker-alpine issues/98](alpinelinux/docker-alpine#98). It is not clear whether: 1. The problem is transient (ie those reporting it are able to get past the problem on a retry); 2. Only affects Mosquitto or potentially affects other Alpine-based IOTstack containers using `apk` to add packages (eg Node-RED); or 3. Environmental (eg if there is a proxy system between the Raspberry Pi and dl-cdn.alpinelinux.org). This Pull Request is implementing the patch suggested by Issue 98 of reverting `apk` requests to use HTTP. Given the march towards HTTPS-everywhere, reverting to HTTP might seem inadvisable but: * Issue 98 was opened in July 2020. * There seems to have been no significant progress towards its resolution since January 2021. * The Discord traffic suggests it is an ongoing and present issue for IOTstack users. Also harmonises Mosquitto Dockerfile on experimental branch with the common versions on master and old-menu branches.
`docker-entrypoint.sh` was out-of-sync with master and old-menu versions. `iotstack_defaults` directory missing.
Adds health-check script to template. Alters Dockerfile to import health-check script and adds `HEALTHCHECK` directive. All container documentation is in master branch.
Paraphraser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A problem affecting the build of the Mosquitto container keeps showing
up in Discord questions. Examples:
The problem is discussed in alpinelinux/docker-alpine issues/98.
It is not clear whether:
the problem on a retry);
IOTstack containers using
apkto add packages (eg Node-RED); orand dl-cdn.alpinelinux.org).
This Pull Request is implementing the patch suggested by Issue 98 of
reverting
apkrequests to use HTTP.Given the march towards HTTPS-everywhere, reverting to HTTP might seem
inadvisable but:
resolution since January 2021.
IOTstack users.
Also harmonises Mosquitto Dockerfile on experimental branch with the
common versions on master and old-menu branches.