LibWasm: Parse i33's #24462
Labels
enhancement
New feature or request
Comments
|
Even though we have #24464, I think we should keep this issue open until full spec compliance is reached (see the PR for more details). |
alimpfard
pushed a commit
that referenced
this issue
May 29, 2024
This works for now, but is technically still not spec compliant. Right now, we're (potentially) missing one bit when reading function indices. See the relevant issue: #24462.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Unfortunately, signed 33-bit integers are part of the WebAssembly spec, and are needed when parsing blocktypes. Currently, we don't have anything to handle this case.
Should we make a special i33 type (to integrate with
Stream::read_value? Or is it okay just to make a special one-off function that'll parse an i33 from the stream? We don't technically need a new datatype, since we can represent it as an i64 that's been parsed in a weird way. We can't really fit it in theLEB128type, sadly.The text was updated successfully, but these errors were encountered: