This repository has been archived by the owner on May 3, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted something a bit more advanced for our language management, so we decided to improve Serpico multi language support.
A finding can now have multiple language
We added a new class in the model : TemplateFindingsTranslation
Thanks to this class, a vulnerability can now have multiple language, wich is more practicale than having the same vulnerability multiple time in different language.
It's easier if you want to modify a field (like finding type or the CVSS parameters), you only have to modify it in one findings instead of in every language version of this findings you made.
When edditing the template database, for each finding you can acces a language panel which allow you to do three things :
Define the language of a finding
If no language was defined for this findings, you can do it from this menu
Add new language to a finding
If the finding doesn't have a translation for one of the language defined in the config file, you can add it from this menu
Select wich language to show
If there is multiple translation for the template, you can show wich one you want to show
Compatible with current multi-language support
Findings translated with the curent version of Serpico will be updated to match the model of the pull request at the first Serpico launch