Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs still being written even though multiadmin_nolog: true #203

Closed
storm37000 opened this issue Feb 28, 2019 · 1 comment
Closed

Logs still being written even though multiadmin_nolog: true #203

storm37000 opened this issue Feb 28, 2019 · 1 comment
Assignees
Labels
Bug Something isn't working v3.0.X Issues related to MultiAdmin v3.0.X

Comments

@storm37000
Copy link

Logs still being written even though multiadmin_nolog: true in the scp_multiadmin.cfg file.

@ButterscotchV ButterscotchV added Bug Something isn't working v3.0.X Issues related to MultiAdmin v3.0.X labels Mar 6, 2019
@ButterscotchV ButterscotchV self-assigned this Mar 6, 2019
@ButterscotchV
Copy link
Collaborator

Closing because this should be fixed, please re-open if you find the latest test version available on the Discord still has this issue, the release #206 is planned to happen soon.

ButterscotchV pushed a commit that referenced this issue Mar 22, 2019
* Handle no SMod better & hopefully fix input bug

- Handles servers not running ServerMod better, doing a simple trick to try soft restarting without ServerMod
- Added "Server#IsStarted" and "Server#IsStarting"
- Hopefully fixed a bug with the InputThread still listening for input while the server is shutting down

* Added SMod build to title & create configs

- MultiAdmin now displays the ServerMod build along with the version
- Configs now store the full config path
- Changed "Config#Path" to "Config#ConfigPath"
- MultiAdmin now creates the config files by default, hopefully this should make configuring MultiAdmin less confusing for new users

* Bump MultiAdmin version to 3.0.1

* New input handler & check description

- Added "Program#ClearConsoleLine()", this prints spaces over the current line to clear it out
- Changed "ColoredConsole#Write()" to re-set the original foreground and background colours instead of setting it to white and black
- Changed Config to use "Utils#GetFullPathSafe()" instead of "Path#GetFullPath()"
- Changed "Utils#TimeStampMessage()" to always accept a timestamp colour
- ColoredConsole should now handle null values better
- Add an error message to OutputHandler initialization if it can't be done correctly
- Rewrite Server Write methods to be based off a single method and branch off
- "Utils#TimeStampMessage()" should no handle null values better
- Wrote a custom input handler for InputThread to solve problems with the input text not staying throughout console messages
 - Listens to key presses in the console and handles them in a switch statement
 - Custom cursor handler with string modification methods
 - Custom paged string section printer for handling long input
 - Custom keyboard bindings for navigating the input area and modifying the text

* Organized code & read description

- Put code in InputThread and MultiAdminConfig into regions to be more organized
- Added "InputThread#BaseSection" as a base input section message
- Added command history to InputThread with a max of 25 commands of history
- Added a super secret config option

* Fixed memory checker not disabling properly

- Fixed MemoryChecker not disabling properly with a value of -1
- Changed MemoryChecker to use floats for MB values
 - Changed Config to use "TryParse" rather than "Convert"
- Added "GetFloat" to Config
- Updated README to reflect config changes

* Origanized & cleaned up MemoryChecker

- Added a region to MemoryChecker
- Added decimals to memory left output
- Changed MemoryChecker to use properties for memory values

* Added missing default values to MultiAdminConfig

* Fixed JoinTextIgnoreNull not taking proper input

* Changed InputThread colours

* Added configs & other changes

- Added config "port"
- Added config "copy_from_folder_on_reload"
- Added config "files_to_copy_from_folder"
- Added "Config#GetStringList()"
- Changed "Program#ClearConsoleLine()" to accept a starting index to optimize line clearing to only clear for past the line to print
- Made "Server#Status" actually set to ServerStatus.Running
- Added file copying on config reload with wildcard support for choosing which files to copy

* Added exit timeouts

- Added server exit and restart timeouts
- Added "server_stop_timeout" and "server_restart_timeout" config options
- Hopefully fixed MemoryChecker spamming console

* Added folder copy queue

- Added folder copy queue
- Added "folder_copy_round_queue" and "randomize_folder_copy_round_queue"
- Added "Server#CopyFromDir()"

* Changed FolderCopyRoundQueue to work on init

* Re-write argument parsing

- Argument parsing now accepts multiple different keys and aliases
- Added "GetFlagFromArgs" which will first try to get a boolean value from the argument, if that fails, then whether the arguments contain the flag is used

* Fixed "multiadmin_nolog" still logging (#203 #205)

* Implement "port"

* Sorted configs

* Config exception handling & close FileStream

* Really trying to get MemoryChecker to stop spamming

- Added checks for whether the server is already supposed to be restarting at the end of the round to MemoryChecker
- Modified README to no longer specify that users will need to create their own config file

* Added "IsGameProcessRunning"

- Added "IsGameProcessRunning" to Server and implemented where it fits
- Changed "GameProcess.Close()" call to "GameProcess.Dispose()"

* Added Server ID entry when all servers are manual-start

* Return default functionality when server folder is empty

* "InputThread.InputPrefix" null check

* Removed explicit paste functionality

* Many changes, read description

- Moved ColorConsole to a new namespace ("ConsoleTools")
- Moved config code to a new namespace ("Config")
- Moved server IO code to a new namespace ("ServerIO")
- Added "Config.GetUInt(string key, uint def = 0)"
- Updated MultiAdminConfig to be able to have limitless hierarchy and store the config values
- Created "ConsoleUtils", this class contains some useful console utilities
- Modified "ConsoleUtils.ClearConsoleLine(int index, bool returnCursorPos = false)" to use Buffer properties rather than Window properties
- Created "ConsolePositioning" class, it's unused, but could be useful in the future
- Added debug logging
  - "multiadmin_debug_log", "multiadmin_debug_log_blacklist", "multiadmin_debug_log_whitelist" config options
  - Logs to it's own file
- Added "port" launch argument
- Switched many cases of checking ".Length" against 0 to a more lazy ".Any()" check
- Updated README to reflect changes
- Added .editorconfig

* Numer of fixes, read description

- Moved StringSections and ShiftingList out of InputThread and into self-contained classes
- Optimized StringSection processing so that it only splits the input text when needed, and stores the result
- Optimized StringSection printing so that it only re-draws the string when needed
- Separated "InputThread#WriteInput()" and "InputThread#SetCursor()" and added "InputThread#WriteInputAndSetCursor()"
- Removed useless "InputThread#SubText()" and "InputThread#AddText()" methods, and replaced with "Remove()" and "Insert()"

* Fixed backspace error when cursor is at index 0

* Made "InputThread#SetCursor()" not run if headless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working v3.0.X Issues related to MultiAdmin v3.0.X
Projects
None yet
Development

No branches or pull requests

2 participants