-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiAdmin Version 3.2.2 Update #218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added double and decimal configs - Make memory checking use decimals - Bump version to 3.2.2
- Fixed "InheritableConfigRegister" being used instead of "ConfigRegister" - Changed "Utils.GetFullPathSafe()" to only check using "string.IsNullOrWhiteSpace()"
- Added IsEmpty extension - Modified MemoryChecker to mainly use longs for byte data and use decimals for megabyte data as to prevent loss - Changed Thread.Abort() usage to Thread.Join()
- Added equality to ColoredMessage - Changed ColoredConsole to be a static class
- Added more unit tests - Added IsEmpty and IsNullOrEmpty for StringBuilder - Changed StringSections to use StringBuilder
- Changed StringMatches to use proper debug logging - Added StringMatches to default debug blacklist - Changed default debug blacklist to use nameof - Updated README.md
- Bumped version to 3.2.2.1 - Fixed potential round end counter integer overflow - Added new config for counting rounds passed when the server is set to restart after a number of rounds, "restart_every_num_rounds_counting"
- Changed attempt delay, increasing it slightly to hopefully account for slower read/write speeds - Added config for max read attempt count "output_read_attempts" - Bumped version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config Changes
StringMatches
to default debug blacklistrestart_every_num_rounds_counting
output_read_attempts
Misc Changes
Utils.GetFullPathSafe()
to only check usingstring.IsNullOrWhiteSpace()
IsEmpty
andIsNullOrEmpty
extension methodsColoredConsole
to be a static classStringSections
to useStringBuilder
string.Equals()
extension for checking equality of sections of a stringStringMatches
to use proper debug loggingBug Fixes
InheritableConfigRegister
being used instead ofConfigRegister
CompareVersionStrings
returning incorrect values