Skip to content

Commit

Permalink
Remove support for SF4
Browse files Browse the repository at this point in the history
  • Loading branch information
loevgaard committed Oct 3, 2023
1 parent 9cabab0 commit cd1e45a
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 24 deletions.
8 changes: 1 addition & 7 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ jobs:
- "highest"

symfony:
- "^4.4"
- "^5.4"

steps:
Expand Down Expand Up @@ -120,7 +119,6 @@ jobs:
- "highest"

symfony:
- "^4.4"
- "^5.4"

steps:
Expand Down Expand Up @@ -164,7 +162,6 @@ jobs:
- "highest"

symfony:
- "^4.4"
- "^5.4"

steps:
Expand Down Expand Up @@ -205,7 +202,6 @@ jobs:
- "highest"

symfony:
- "^4.4"
- "^5.4"

steps:
Expand All @@ -231,9 +227,7 @@ jobs:
dependency-versions: "${{ matrix.dependencies }}"

- name: "Lint container"
# Do not lint on SF4 because we get this error: Invalid definition for service "doctrine.migrations.dependency_factory": argument 2 of "Doctrine\Migrations\DependencyFactory::setDefinition()" accepts "callable", "SyliusLabs\DoctrineMigrationsExtraBundle\Factory\ContainerAwareVersionFactory" passed.
# Note: We cannot use the if statement here, because of https://gh.neting.ccmunity/t/matrix-cannot-be-used-in-jobs-level-if/17177/10
run: 'if [ "${{ matrix.symfony }}" != "^4.4" ]; then (cd tests/Application && bin/console lint:container); fi'
run: "(cd tests/Application && bin/console lint:container)"

- name: "Create database"
run: "(cd tests/Application && bin/console doctrine:database:create -vvv)"
Expand Down
33 changes: 16 additions & 17 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@
"setono/doctrine-object-manager-trait": "^1.1",
"setono/symfony-main-request-trait": "^1.0",
"sylius/resource-bundle": "^1.6",
"symfony/config": "^4.4 || ^5.4 || ^6.0",
"symfony/console": "^4.4 || ^5.4 || ^6.0",
"symfony/dependency-injection": "^4.4 || ^5.4 || ^6.0",
"symfony/event-dispatcher": "^4.4 || ^5.4 || ^6.0",
"symfony/form": "^4.4 || ^5.4 || ^6.0",
"symfony/http-foundation": "^4.4 || ^5.4 || ^6.0",
"symfony/messenger": "^4.4 || ^5.4 || ^6.0",
"symfony/routing": "^4.4 || ^5.4 || ^6.0",
"symfony/validator": "^4.4 || ^5.4 || ^6.0",
"symfony/workflow": "^4.4 || ^5.4 || ^6.0",
"symfony/config": "^5.4 || ^6.4",
"symfony/console": "^5.4 || ^6.4",
"symfony/dependency-injection": "^5.4 || ^6.4",
"symfony/event-dispatcher": "^5.4 || ^6.4",
"symfony/form": "^5.4 || ^6.4",
"symfony/http-foundation": "^5.4 || ^6.4",
"symfony/messenger": "^5.4 || ^6.4",
"symfony/routing": "^5.4 || ^6.4",
"symfony/validator": "^5.4 || ^6.4",
"symfony/workflow": "^5.4 || ^6.4",
"twig/twig": "^2.15",
"webmozart/assert": "^1.11"
},
Expand All @@ -39,17 +39,16 @@
"phpunit/phpunit": "^9.5",
"psalm/plugin-phpunit": "^0.17",
"psalm/plugin-symfony": "^3.1",
"roave/security-advisories": "dev-latest",
"setono/code-quality-pack": "^2.2",
"sylius/admin-api-bundle": "^1.11",
"sylius/sylius": "~1.10.14",
"symfony/debug-bundle": "^4.4 || ^5.4 || ^6.0",
"symfony/dotenv": "^4.4 || ^5.4 || ^6.0",
"symfony/intl": "^4.4 || ^5.4 || ^6.0",
"symfony/debug-bundle": "^5.4 || ^6.4",
"symfony/dotenv": "^5.4 || ^6.4",
"symfony/intl": "^5.4 || ^6.4",
"symfony/maker-bundle": "^1.39",
"symfony/property-info": "^4.4 || ^5.4 || ^6.0",
"symfony/serializer": "^4.4 || ^5.4 || ^6.0",
"symfony/web-profiler-bundle": "^4.4 || ^5.4 || ^6.0",
"symfony/property-info": "^5.4 || ^6.4",
"symfony/serializer": "^5.4 || ^6.4",
"symfony/web-profiler-bundle": "^5.4 || ^6.4",
"symfony/webpack-encore-bundle": "^1.15"
},
"prefer-stable": true,
Expand Down

0 comments on commit cd1e45a

Please sign in to comment.