Cleanup

Shadnix-was-taken · May 28, 2021 · 0314f65 · 0314f65
1 parent 7843698
commit 0314f65
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/ParticleOverdrive/Controllers/WorldParticleController.cs b/ParticleOverdrive/Controllers/WorldParticleController.cs
@@ -42,6 +42,7 @@ public void Init(bool state)
 
         private ParticleSystem Find()
         {
+            // This needs updating, as this doesn't find inactive Objects and the menu object persists now
             ParticleSystem[] pss = FindObjectsOfType<ParticleSystem>();
             return pss.Where(x => x.name == "DustPS").FirstOrDefault();
         }

diff --git a/ParticleOverdrive/Plugin.cs b/ParticleOverdrive/Plugin.cs
@@ -24,7 +24,6 @@ public class Plugin
         public static GameObject _controller;
         public static WorldParticleController _particleController;
         public static CameraNoiseController _noiseController;
-        internal static bool IsBSMLMenuLoaded = false;
 
         #region Private Field Getters
         internal static RefGetter<NoteCutParticlesEffect, ParticleSystem> GetExplosionPS;
@@ -138,6 +137,7 @@ public void OnStart()
             }
 
             AddEvents();
+            BSMLSettings.instance.AddSettingsMenu("Particle Overdrive", "ParticleOverdrive.UI.POUI.bsml", UI.POUI.instance);
         }
 
         [OnExit]
@@ -148,11 +148,6 @@ public void OnExit()
 
         public void OnActiveSceneChanged(Scene prevScene, Scene scene)
         {
-            if (scene.name == "MainMenu" && !IsBSMLMenuLoaded)
-            {
-                BSMLSettings.instance.AddSettingsMenu("Particle Overdrive", "ParticleOverdrive.UI.POUI.bsml", UI.POUI.instance);
-                IsBSMLMenuLoaded = true;
-            }
             LoadConfig();
             if (!CameraNoiseWorldParticlesEnabled)
                 return;