iluwatar#105 Updates as per Sonar checks

Shanty97 · Feb 11, 2024 · 79037ac · 79037ac
1 parent 31377d7
commit 79037ac
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/main/java/math/DiceThrow.java b/src/main/java/math/DiceThrow.java
@@ -31,6 +31,8 @@
  */
 public class DiceThrow {
 
+  private static Random random = new Random();
+
   /**
   * Enum for standardized sided dice (4,6,8,10,12 and 20).
   */
@@ -59,14 +61,14 @@ public int getDiceSides() {
   * Returns the sum of sides for the given number of sides of each dice.
   *
   * @param noOfDice number of dice
-  * @param diceSides sides of a dice
+  * @param sides sides of a dice
   * @return int sum of sides for number of dice
   */
-  public static int throwDice(int noOfDice, DiceSides diceSides) {
+  public static int throwDice(int noOfDice, DiceSides sides) {
 
     int sum = 0;
     for (int i = 0; i < noOfDice; i++) {
-      sum = sum + (1 + new Random().nextInt(diceSides.getDiceSides()));
+      sum = sum + (1 + random.nextInt(sides.getDiceSides()));
     }
 
     return sum;

diff --git a/src/test/java/math/DiceThrowTest.java b/src/test/java/math/DiceThrowTest.java
@@ -24,6 +24,7 @@
 
 package math;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import math.DiceThrow.DiceSides;
@@ -46,7 +47,7 @@ void test_throwDice() {
     assertTrue(DiceThrow.throwDice(4, DiceSides.TEN) <= 40);
     assertTrue(DiceThrow.throwDice(1, DiceSides.TWELVE) <= 12);
     assertTrue(DiceThrow.throwDice(2, DiceSides.TWENTY) <= 40);
-    assertTrue(DiceThrow.throwDice(0, DiceSides.FOUR) == 0);
+    assertEquals(0, DiceThrow.throwDice(0, DiceSides.FOUR));
 
   }
 }