Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning in PHP 7.3 using 'continue' in switch statement #8

Closed
gallien opened this issue Jul 14, 2019 · 3 comments
Closed

Warning in PHP 7.3 using 'continue' in switch statement #8

gallien opened this issue Jul 14, 2019 · 3 comments

Comments

@gallien
Copy link

gallien commented Jul 14, 2019

see

and following lines

'continue' in switch statements are deprecated:
https://wiki.php.net/rfc/continue_on_switch_deprecation

I think, 'continue' should be changed to 'break' in all case statements in this method.

In PHP 7.3 it shows warnings like
Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in ...

@Shardj
Copy link
Owner

Shardj commented Jul 15, 2019

Thanks, I'll get that sorted

@Shardj
Copy link
Owner

Shardj commented Jul 15, 2019

Looking at the debug log it seems to me that it should be continue 2 as it's trying to skip the $cmapType = $format; on line 934

@Shardj
Copy link
Owner

Shardj commented Jul 15, 2019

Fixed by commit: 4c70923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants