-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Zend_Session_SaveHandler_DbTable->write triggering warning #23
Conversation
Mute warning when using Zend_Session_SaveHandler_DbTable.
Hi, what warning are you getting? It's better for you to simply fix warnings rather than supress them. |
update returns 0 if the data being updated matches the one in the database, which produces a `false` return, which in turn triggers a warning in Zend_Session::writeClose - session_write_close()
@Shardj I took the time to find and fix the bug in the best possible way. In this case, the chain of events is
If there is an error on the configuration, the update will throw an exception instead of returning 0. |
Alright, thanks. This is an annoying php 7 change. But since try catch for Zend_Session_SaveHandler_Exception should be used to detect issues when writing data anyway it's acceptable. I'll tag this as a major change as it can possibly change functionality for some people. |
Sorry wrong button there |
This is now part of release-1.15.0 |
Mute warning when using Zend_Session_SaveHandler_DbTable.