Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ForceIndex function to DB Select.php #350

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

broqit
Copy link

@broqit broqit commented May 18, 2023

No description provided.

@develart-projects develart-projects self-requested a review August 9, 2023 08:33
@develart-projects develart-projects added the enhancement New feature or request label Aug 9, 2023
* @see Zend_Db_Select::_getForceIndexForTable
* @return string
*/
protected function _renderForceIndex($sql)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is here, could you please remove that? I would like to merge this one, thanks.

@develart-projects develart-projects added this to the 1.23.0 milestone Aug 9, 2023
@develart-projects develart-projects added the requested change some changes are needed before the merge label Aug 9, 2023
develart-projects added a commit to develart-projects/zf1-future that referenced this pull request Aug 10, 2023
@develart-projects develart-projects removed this from the 1.23.0 milestone Aug 10, 2023
@develart-projects
Copy link
Collaborator

I have included this change in #364 with change requested to get it into 1.23.0 release.

@develart-projects
Copy link
Collaborator

We have to postpone this, need to find out why tests are failing:

There were 172 errors:

1) Zend_Db_Select_StaticTest::testSelect
Undefined array key "forceindex"

/home/runner/work/zf1-future/zf1-future/library/Zend/Db/Select.php:1424
/home/runner/work/zf1-future/zf1-future/tests/Zend/Db/Select/StaticTest.php:49
/home/runner/work/zf1-future/zf1-future/tests/resources/Runner.php:20
/home/runner/work/zf1-future/zf1-future/tests/Zend/AllTests.php:143
/home/runner/work/zf1-future/zf1-future/tests/Zend/AllTests.php:267

@develart-projects develart-projects added this to the 1.24.0 milestone Aug 10, 2023
develart-projects added a commit to develart-projects/zf1-future that referenced this pull request Aug 10, 2023
@hungtrinh
Copy link

Sorry I don't think add functional to Zend Framework it's good idea. now ZF in maintain phrase (not development phrase ) so with new functional please extends and move it's to personal package.

@develart-projects
Copy link
Collaborator

develart-projects commented Aug 11, 2023

@hungtrinh I mainly agree, but if someone creates update with tests, why to drop it? It can definitely help to someone else. An we are still maintaining minor/major versioning.

@hungtrinh
Copy link

So that means, we need to write a manual guide and a gen API doc somewhere to propagate about new functions too.

In case we add new feature X right now in the near future will add features Y,Z, etc.

@develart-projects
Copy link
Collaborator

@hungtrinh we can consider autogen. Should be enough, if correctly docbloc-ked :) But we are talking here about modest updates, like adding new connector, or eg. "insert on duplicate update" DB function, what is something really missing in ZF1 and I'm considering to mainline it in the future.

@develart-projects develart-projects marked this pull request as draft August 23, 2023 12:51
@develart-projects develart-projects removed this from the 1.24.0 milestone Sep 27, 2023
@tsmgeek
Copy link

tsmgeek commented Dec 12, 2023

This was discussed back in #77 and muted, there was a previous full implementation of FORCE/USE/IGNORE index way back when.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requested change some changes are needed before the merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants