-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ForceIndex function to DB Select.php #350
base: master
Are you sure you want to change the base?
Conversation
* @see Zend_Db_Select::_getForceIndexForTable | ||
* @return string | ||
*/ | ||
protected function _renderForceIndex($sql) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this is here, could you please remove that? I would like to merge this one, thanks.
I have included this change in #364 with change requested to get it into 1.23.0 release. |
We have to postpone this, need to find out why tests are failing:
|
Sorry I don't think add functional to Zend Framework it's good idea. now ZF in maintain phrase (not development phrase ) so with new functional please extends and move it's to personal package. |
@hungtrinh I mainly agree, but if someone creates update with tests, why to drop it? It can definitely help to someone else. An we are still maintaining minor/major versioning. |
So that means, we need to write a manual guide and a gen API doc somewhere to propagate about new functions too. In case we add new feature X right now in the near future will add features Y,Z, etc. |
@hungtrinh we can consider autogen. Should be enough, if correctly docbloc-ked :) But we are talking here about modest updates, like adding new connector, or eg. "insert on duplicate update" DB function, what is something really missing in ZF1 and I'm considering to mainline it in the future. |
This was discussed back in #77 and muted, there was a previous full implementation of FORCE/USE/IGNORE index way back when. |
No description provided.