Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SoundCloud] Detect whether there are any more search results #41

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ShareASmile
Copy link
Owner

@ShareASmile ShareASmile commented Jun 13, 2024

Previously, the extractor always assumed that there was an infinite number of search results. That has caused some problems. When searching for something with only a few results, that could cause clients such as NewPipe to try to load more results without getting more and thus causing tons of requests, ultimately resulting in reCaptcha requests.

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Previously, the extractor always assumed that there was an infinite number of search results. That has caused some problems. When searching for something with only a few results, that could cause clients such as NewPipe to try to load more results without getting more and thus causing tons of requests, ultimately resulting in reCaptcha requests.

Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
@ShareASmile ShareASmile merged commit b8b8d65 into master Jun 13, 2024
1 check failed
ShareASmile added a commit to ShareASmile/NewPipeZing that referenced this pull request Jun 13, 2024
Copy this commit by StyPox
TeamNewPipe@e236d37
Fixes TeamNewPipe#10012

Also Update Extractor to Detect whether for SoundCloud there are any more search results
ShareASmile/NewPipeExtractor#41

Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
Co-Authored-By: Stypox <stypox@pm.me>
ShareASmile added a commit to ShareASmile/NewPipeZing that referenced this pull request Jun 13, 2024
1. Copy this commit by StyPox
TeamNewPipe@e236d37
Fixes TeamNewPipe#10012

2. Update Extractor to Detect whether for SoundCloud there are any more search results
ShareASmile/NewPipeExtractor#41

Update date time library prettytime to 5.0.8.Final
Fixes: TeamNewPipe#11092

3. Fixes: Upload dates have a minus prepended if they're in the past and language is set to Ukrainian
Fixed in ocpsoft/prettytime#270

Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
Co-Authored-By: Stypox <stypox@pm.me>
Co-Authored-By: moontoaster <74986506+moontoaster@users.noreply.github.com>
ShareASmile added a commit to ShareASmile/FoxPipe that referenced this pull request Jun 13, 2024
…search results ShareASmile/NewPipeExtractor#41

Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
ShareASmile added a commit to ShareASmile/NewPipeZing that referenced this pull request Jun 13, 2024
…dCloud there are any more search results ShareASmile/NewPipeExtractor#41

Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
ShareASmile added a commit to ShareASmile/NewPipeZing that referenced this pull request Jun 13, 2024
 SoundCloud there are any more search results ShareASmile/NewPipeExtractor#41

Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
ShareASmile added a commit to ShareASmile/FoxPipe that referenced this pull request Jun 14, 2024
…t whether for

 SoundCloud there are any more search results ShareASmile/NewPipeExtractor#41

Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
ShareASmile added a commit to ShareASmile/NewPipe-Legacy-Revo that referenced this pull request Jun 14, 2024
for SoundCloud there are any more search results ShareASmile/NewPipeExtractor#41

Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
@ShareASmile ShareASmile deleted the fix/sc/search-next-page branch July 13, 2024 15:33
Repository owner locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant