forked from TeamNewPipe/NewPipeExtractor
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SoundCloud] Detect whether there are any more search results #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the extractor always assumed that there was an infinite number of search results. That has caused some problems. When searching for something with only a few results, that could cause clients such as NewPipe to try to load more results without getting more and thus causing tons of requests, ultimately resulting in reCaptcha requests. Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
ShareASmile
added a commit
to ShareASmile/NewPipeZing
that referenced
this pull request
Jun 13, 2024
Copy this commit by StyPox TeamNewPipe@e236d37 Fixes TeamNewPipe#10012 Also Update Extractor to Detect whether for SoundCloud there are any more search results ShareASmile/NewPipeExtractor#41 Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com> Co-Authored-By: Stypox <stypox@pm.me>
ShareASmile
added a commit
to ShareASmile/NewPipeZing
that referenced
this pull request
Jun 13, 2024
1. Copy this commit by StyPox TeamNewPipe@e236d37 Fixes TeamNewPipe#10012 2. Update Extractor to Detect whether for SoundCloud there are any more search results ShareASmile/NewPipeExtractor#41 Update date time library prettytime to 5.0.8.Final Fixes: TeamNewPipe#11092 3. Fixes: Upload dates have a minus prepended if they're in the past and language is set to Ukrainian Fixed in ocpsoft/prettytime#270 Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com> Co-Authored-By: Stypox <stypox@pm.me> Co-Authored-By: moontoaster <74986506+moontoaster@users.noreply.github.com>
ShareASmile
added a commit
to ShareASmile/FoxPipe
that referenced
this pull request
Jun 13, 2024
…search results ShareASmile/NewPipeExtractor#41 Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
ShareASmile
added a commit
to ShareASmile/NewPipeZing
that referenced
this pull request
Jun 13, 2024
…dCloud there are any more search results ShareASmile/NewPipeExtractor#41 Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
ShareASmile
added a commit
to ShareASmile/NewPipeZing
that referenced
this pull request
Jun 13, 2024
SoundCloud there are any more search results ShareASmile/NewPipeExtractor#41 Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
ShareASmile
added a commit
to ShareASmile/FoxPipe
that referenced
this pull request
Jun 14, 2024
…t whether for SoundCloud there are any more search results ShareASmile/NewPipeExtractor#41 Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
ShareASmile
added a commit
to ShareASmile/NewPipe-Legacy-Revo
that referenced
this pull request
Jun 14, 2024
for SoundCloud there are any more search results ShareASmile/NewPipeExtractor#41 Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
Repository owner
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the extractor always assumed that there was an infinite number of search results. That has caused some problems. When searching for something with only a few results, that could cause clients such as NewPipe to try to load more results without getting more and thus causing tons of requests, ultimately resulting in reCaptcha requests.