Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Add: Upgrade components in SPFx development with SPSE #9215

Closed
wants to merge 2 commits into from

Conversation

WesleyFive
Copy link
Contributor

Category

  • Content fix
  • New article

Related issues

N/A

What's in this Pull Request?

Add a new article to introduce how to upgrade components in SPFx development with SPSE.
Signing off by SharePoint Server PG, POC: Wesley Wu

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit a1f0fac:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/spfx/sharepoint-subscription-edition-component.md ⚠️Warning View Details
docs/images/spfx-component-upgrade-code-import-01.png ✅Succeeded View
docs/images/spfx-component-upgrade-package-json-01.png ✅Succeeded View
docs/images/spfx-component-upgrade-tsconfig-json-01.png ✅Succeeded View
docs/spfx/supported-extensibility-platforms-overview.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

docs/spfx/sharepoint-subscription-edition-component.md

  • Line 45, Column 5: [Warning: duplicate-alt-text - See documentation] Alt text 'Microsoft Teams Lead Assistant Dashboard in SharePoint' is duplicated. Within an article, alt text must be unique.
  • Line 59, Column 9: [Warning: duplicate-alt-text - See documentation] Alt text 'Microsoft Teams Lead Assistant Dashboard in SharePoint' is duplicated. Within an article, alt text must be unique.
  • Line 87, Column 9: [Warning: duplicate-alt-text - See documentation] Alt text 'Microsoft Teams Lead Assistant Dashboard in SharePoint' is duplicated. Within an article, alt text must be unique.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@WesleyFive WesleyFive marked this pull request as draft September 18, 2023 16:45
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 8e5f995:

✅ Validation status: passed

File Status Preview URL Details
docs/images/spfx-component-upgrade-code-import-01.png ✅Succeeded View
docs/images/spfx-component-upgrade-package-json-01.png ✅Succeeded View
docs/images/spfx-component-upgrade-tsconfig-json-01.png ✅Succeeded View
docs/spfx/sharepoint-subscription-edition-component.md ✅Succeeded View
docs/spfx/supported-extensibility-platforms-overview.md ✅Succeeded View
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@WesleyFive WesleyFive marked this pull request as ready for review September 18, 2023 17:18
@andrewconnell andrewconnell self-assigned this Sep 18, 2023
@andrewconnell andrewconnell added pr:in-review Actively reviewing pull request pr:do-not-merge Pull request not ready to be merged and removed pr:in-review Actively reviewing pull request labels Sep 18, 2023
Copy link
Collaborator

@andrewconnell andrewconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the inline comments, what about customers who upgraded/deployed SPFx projects based on v1.5.1 that was added as part of the SP SE 23H1 update?

If 23H2 only includes SPFx v1.5.0, those projects based on SPFx v1.5.1 would break, because the dependencies are no longer there. Seems the docs should at least call that out and warn/advise customers to downgrade their projects.


SharePoint Server Subscription Edition supports SharePoint Framework client-side web parts in classic and modern pages, and extensions in modern pages.

When developing a client-side web part, you can only use the specific versions of components supported by the SharePoint Framework to make the web part compatible with your SharePoint Server.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also mention SPFx extensions are those are also supported in SPFx v1.3.x+, such as application customizers & field customizers as they can also use React & Fluent UI React so they'd also be included in this doc, correct?


## Upgrade React and Fluent UI React

The SharePoint Framework v1.4.1 natively supports React v15.8 and Fluent UI React ([formerly Office UI Fabric React](https://devblogs.microsoft.com/microsoft365dev/ui-fabric-is-evolving-into-fluent-ui/)) v5.17.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes the reader is on SP SE GA... SP SE 23H1 updated SPFx to v1.5.1... should that be incorporated in this statement?


If you want to use React v16 or Fluent UI React v7 in your custom web parts developed for SharePoint Server with the SharePoint Framework v1.5.0, here are the instructions:

1. Modify the "dependencies" and "devDependencies" in the npm project:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these manual steps to change the versions of SPFx project can be implemented using a script specifying specific versions to install. These steps don't address the package-lock.json file which would also need to be updated if you manually edit these version numbers.

But if you instead used a script, it would incorporate those changes in not just the package.json but also the package-lock.json file. Furthermore, it's generally accepted guidance to use NPM scripts to upgrading NPM packages, not to manually edit the package.json file.

For example, the first bullet point could be replaced with:

npm install react@16.13.1 react-dom@16.13.1 @types/react@16.9.51 @types/react-dom@16.9.8 @microsoft/office-ui-fabric-react-bundle@1.15.0 -SE
npm install @microsoft/sp-build-web@1.9.1 @microsoft/sp-module-interfaces@1.9.1 -DE


- Add **gulp-json-editor**: "2.2.1", **@microsoft/sp-tslint-rules**: "1.9.1", and **@microsoft/rush-stack-compiler-2.9**: "0.7.16" to the "devDependencies" section.

- Change the rest of the SPFx components from version "1.4.0" or "1.4.1" to "1.5.0".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about those who deployed SPFx v1.5.1 as part of the 23H1-supported version?

@@ -20,6 +20,8 @@ Learn more about using SPFx on SharePoint Online: [SPFx support for SharePoint O
> [!IMPORTANT]
> SharePoint Server Subscription Edition (SE), announced as a preview in July 2021, supports the same SPFx versions as SharePoint Server 2019.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this get removed as SPSE 23H1 added support for newer versions than what was supported in SP 2019?

@VesaJuvonen
Copy link
Contributor

Closing based on the chat with the Subscription Edition team - new updates coming for this semester hopefully soon.

@andrewconnell
Copy link
Collaborator

Would this also apply to #9230?

@rtonerii
Copy link

So, yeah, this whole SPFx on SPSE thing is feeling like a roadblock, right? We were promised shiny new features and regular updates, but things haven't exactly been at any speed I ever expected. My clients have cold feet (And I'm not talking about the cold weather down here!) about SPSE because of those SPFx limitations, and with SP2019 EOL, there is a large concern here.

Here's the deal, we need Microsoft to get real with us. Are they going to keep pumping up SPFx for SPSE, or is it stuck with not having regular updates forever? SPFx for SPO and on-prem are in no way close, I don't need Graph Services, I could go on but I am trying to keep this short and to the point.

And while we're at it, a little transparency wouldn't hurt. A roadmap, a plan, anything to show us they're not just throwing empty promises into the void. Remember that whole "long-term investment" thing Bill Bär mentioned back in March? Yeah, we're still waiting for the investment part to kick in.

Bottom line, this whole situation stinks, please put some real effort in the ugly stepchild we are all seeing.

@rtonerii
Copy link

Any update?

The recent SharePoint Server Subscription Edition Version 24H1 release https://learn.microsoft.com/en-us/sharepoint/what-s-new/new-and-improved-features-in-sharepoint-server-subscription-edition-24h1-release is exciting. However, I couldn't find any information about updates to the supported SharePoint Framework (SPFx) version.

Does this imply that SPFx development won't see further improvements within the on-premises Subscription Edition?

Many of my clients require on-premises storage for their content. SPFx integration with Subscription Edition is crucial for their customization needs.

It feels like the combination of SharePoint Server Subscription Edition and SPFx is not receiving the same level of attention (not even close) as SharePoint Online.

Could you please clarify Microsoft's plans for SPFx support within the on-premises Subscription Edition moving forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:do-not-merge Pull request not ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants