-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Control: Taxonomy Picker #22
Comments
@russgove, @estruyf |
@estruyf @russgove |
That is great @spdavid. It might be interesting to get it first included in the Property Pane controls project. Here is the corresponding feature request: pnp/sp-dev-fx-property-controls#11 |
Ok sounds good. Ill start with it there and then port it over to this repo. |
Hi @spdavid , Do you have any plans on when you'll working on it? shy :) I need that kind of control in my current project and am planning to work on it in next two weeks or so... |
I plan on having the property control version fixed this weekend. And port it over to this one during the beginning of next week. |
@spdavid that's awesome! :) |
@AJIXuMuK Just a status update for you :). Got pretty far on the weekend. Just need to style a bit and set up the tests. I opted to use the base picker from the fabric UI so i can customize it a bit more and use a custom interface and rendering. So its taking a bit longer. Might not have so much time this week but I will be finishing up this upcoming weekend. |
Thanks @spdavid! I really appreciate that you're informing me :) |
pnp/sp-dev-fx-property-controls#39 Pull request made in the sp-dev-fx-property-controls repo. Will port over the code to this repo next. But a few things to discuss. Do we want this Taxonomy Picker to search through the termstore, group and termset. I'm thinking termset, all terms, and perhaps enterprise keywords. I have found the group scenario is a bit tricky and the api does not support it in a good way. Feedback on this matter is welcome 👍 |
I would say that it should be also "filterable" to a specific term. Additionally, if I remember correctly, the initial |
@spdavid great! Thanks for contributing. I would limit it to a specific term set, not a group / multiple term sets as this is the functionality the other term picker control provides. |
Great. Almost finished. Limited to a termset only and have AnchorId as an optional prop. Will be ready in a day or two. |
@spdavid, how soon could you have a complete control for any dev use. I am getting a push for a similar control from my team. I am asking them to wait with hopes to not reinvent the wheel. May be we can use a dev copy to evaluate while this control comes to fruition. Happy to contribute for it too and move it faster. Sorry for the push but would not want us to reinvent the wheel if we can use this control. |
@AsishP |
@spdavid, no probs. Thanks for looking to prioritize this. |
@AsishP Pull Request made. |
@spdavid, thanks for the update. Will get the PR and use it for future implementations. In current case, because of urgency, we happen to implement our own version of Taxonomy control extracting the logic from property pane picker control in https://github.com/SharePoint/sp-dev-fx-property-controls. Quick fyi, found an issue with use of termset GUID in the code from property pane picker control. If you are using the same logic. please see the fix here in the issue submitted - pnp/sp-dev-fx-property-controls#48 Thanks again. |
@AsishP I have added the same change as to the property control. The More information about installing beta versions can be found here: https://sharepoint.github.io/sp-dev-fx-controls-react/beta/ |
[x ] Enhancement
A taxonomy picker control that works similarly to the classic one.
The text was updated successfully, but these errors were encountered: