Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Control: Taxonomy Picker #22

Closed
russgove opened this issue Dec 19, 2017 · 19 comments
Closed

New Control: Taxonomy Picker #22

russgove opened this issue Dec 19, 2017 · 19 comments
Milestone

Comments

@russgove
Copy link
Contributor

[x ] Enhancement

A taxonomy picker control that works similarly to the classic one.

@AJIXuMuK
Copy link
Collaborator

@russgove, @estruyf
there is a term picker control for Property Pane (https://sharepoint.github.io/sp-dev-fx-property-controls/controls/PropertyFieldTermPicker/).
Does it make sense to just "transfer" this control to this repo as well?

@spdavid
Copy link
Contributor

spdavid commented Mar 17, 2018

@estruyf @russgove
I'm thinking the best thing would be to create something similar to the OOB picker and have suggestions when typing and have the picker icon that has similar behavior to the Property Pane Picker with a popup or panel from the side. I'm looking for a good challenge and can work on this one if nobody else has started yet.

@estruyf
Copy link
Member

estruyf commented Mar 19, 2018

That is great @spdavid. It might be interesting to get it first included in the Property Pane controls project. Here is the corresponding feature request: pnp/sp-dev-fx-property-controls#11

@spdavid
Copy link
Contributor

spdavid commented Mar 19, 2018

Ok sounds good. Ill start with it there and then port it over to this repo.

@AJIXuMuK
Copy link
Collaborator

Hi @spdavid ,

Do you have any plans on when you'll working on it? shy :)

I need that kind of control in my current project and am planning to work on it in next two weeks or so...
So, just wanted to know if there is a probability that you'd finish yours or I'll just need to work in parallel :)

@spdavid
Copy link
Contributor

spdavid commented Mar 23, 2018

I plan on having the property control version fixed this weekend. And port it over to this one during the beginning of next week.

@AJIXuMuK
Copy link
Collaborator

@spdavid that's awesome! :)

@spdavid
Copy link
Contributor

spdavid commented Mar 28, 2018

@AJIXuMuK Just a status update for you :). Got pretty far on the weekend. Just need to style a bit and set up the tests. I opted to use the base picker from the fabric UI so i can customize it a bit more and use a custom interface and rendering. So its taking a bit longer. Might not have so much time this week but I will be finishing up this upcoming weekend.

@AJIXuMuK
Copy link
Collaborator

Thanks @spdavid! I really appreciate that you're informing me :)
Most probably I'll start with some basement by end of this week but will look forward to hearing from you :)

@spdavid
Copy link
Contributor

spdavid commented Apr 3, 2018

pnp/sp-dev-fx-property-controls#39

Pull request made in the sp-dev-fx-property-controls repo. Will port over the code to this repo next.

But a few things to discuss. Do we want this Taxonomy Picker to search through the termstore, group and termset. I'm thinking termset, all terms, and perhaps enterprise keywords. I have found the group scenario is a bit tricky and the api does not support it in a good way.

Feedback on this matter is welcome 👍

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Apr 3, 2018

I would say that it should be also "filterable" to a specific term.
Use Case: Managed Metadata Field that is tied to a Term, not Term Set.

Additionally, if I remember correctly, the initial PropertyFieldTermPicker control's tree doesn't support nested terms (terms in terms)...

@estruyf
Copy link
Member

estruyf commented Apr 3, 2018

@spdavid great! Thanks for contributing.

I would limit it to a specific term set, not a group / multiple term sets as this is the functionality the other term picker control provides.

@spdavid
Copy link
Contributor

spdavid commented Apr 11, 2018

Great. Almost finished. Limited to a termset only and have AnchorId as an optional prop. Will be ready in a day or two.

@AsishP
Copy link
Contributor

AsishP commented Apr 12, 2018

@spdavid, how soon could you have a complete control for any dev use. I am getting a push for a similar control from my team. I am asking them to wait with hopes to not reinvent the wheel. May be we can use a dev copy to evaluate while this control comes to fruition. Happy to contribute for it too and move it faster.

Sorry for the push but would not want us to reinvent the wheel if we can use this control.

@spdavid
Copy link
Contributor

spdavid commented Apr 13, 2018

@AsishP
Thanks for your comment. I'm literally a few hours a way from finish. Tonight or tomorrow morning. Its been a busy week and I'm developing it in my free time as I'm to busy with my regular work. Almost ready.

@AsishP
Copy link
Contributor

AsishP commented Apr 13, 2018

@spdavid, no probs. Thanks for looking to prioritize this.

@spdavid
Copy link
Contributor

spdavid commented Apr 16, 2018

@AsishP Pull Request made.

@AsishP
Copy link
Contributor

AsishP commented Apr 17, 2018

@spdavid, thanks for the update. Will get the PR and use it for future implementations. In current case, because of urgency, we happen to implement our own version of Taxonomy control extracting the logic from property pane picker control in https://github.com/SharePoint/sp-dev-fx-property-controls.

Quick fyi, found an issue with use of termset GUID in the code from property pane picker control. If you are using the same logic. please see the fix here in the issue submitted - pnp/sp-dev-fx-property-controls#48

Thanks again.

@estruyf
Copy link
Member

estruyf commented Apr 17, 2018

@AsishP I have added the same change as to the property control.

The TaxonomyPicker control is now available in the latest beta release. Feel free to check it out.

More information about installing beta versions can be found here: https://sharepoint.github.io/sp-dev-fx-controls-react/beta/

@estruyf estruyf added this to the 1.3.0 milestone Apr 17, 2018
@estruyf estruyf closed this as completed Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants