-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated PropertyFieldTermPicker to be able to pick terms as close to the OOB Term picker in sharepoint #39
Conversation
CircleCI failed. Works on my computer. :) Seems there is a Node version difference. Not sure if this can be the problem or not. CircleCI versions My Versions |
@spdavid thanks, will take a look at it this week. It cannot build, because you references this Something I always do is running my jobs like this: |
Would you also be able to write the documentation for your control? Current documentation can be found here: https://github.com/SharePoint/sp-dev-fx-property-controls/tree/master/docs/documentation/docs |
change to the Lib import fixed the problem. Documentation will be updated soon. |
Documentation updated. and one small bug fix for local workbench |
@spdavid you just added new things while I was doing the merge :-). Will try to add these things as well. BTW: did a small code change to the suggestion list. All selected terms are now filtered out so that you cannot have duplicates. |
@spdavid it got merged. Thanks for the Term Picker updates! |
Awesome job! |
What's in this Pull Request?
Changed ICheckedTerm.Id to ICheckedTerm.Key so it would work as an interface in the BasePicker
Added ICheckedTerm.TermSetName property to interface so it can be shown in the custom rendering of the suggestions of the TermPicker
Changed ICheckedTerm to IPickerTerm for semantic reasons
Created New TermPicker Component Inheriting from BasePicker. Use custom Rendering for suggestions and Tag Rendering.
Removed Texbox and Added Custom TermPicker Component in the PropertyFieldTermPickerHost
Added Functionality to SPTermStorePickerService to support the TermPicker autocompletion
Note: Might be some breaking changes here. EG. ICheckedTerm namechange and change from ID to Key. Had to make some decisions here as there were a lot of changes and didn't see a way around it without redundant data.
Other Notes: When searching terms when limitByGroupNameOrID there can be performance issues with large termsets as i loop through each. There is no group.getTerms method. There may be room for optimization here when I think of something better.
Sorry for the large pull request. :)