skip take & select fields

[nzdev]

For paging and better performance there's a new SkipTake method available on search results. Prior to this if using the built in Skip method for paging it would still allocate search results for the items being skipped. With SkipTake this is no longer the case.

---

Original issue:

What:
Skip and Take implementation that does not collect skipped documents. Select only required fields

Why?
Saves on allocating skipped documents. Separate implementation to existing skip as this one can only be called once, so if you need to get another page, you need to run the query again, unlike using maxresults.

when calling ExecuteWithSkip(int pageSize, int numberOfResultsToSkip), then when calling .Skip(int numberOfResultsToSkip) use .Skip(0) as the results have already been skipped.

[Shazwazza]

Great stuff, I didn't realize you could skip over the docs. I have left some notes about breaking changes again and it seems like the PR for field inclusions has leaked into this one if that can be fixed up?

[nzdev]

@Shazwazza updates made

[Shazwazza]

Thanks! Have merged to a temporary branch for now as I think there's some mods I'd like to make before merging to master. Cheers!

[nzdev]

Thanks @Shazwazza I'll update the umbraco pr once this is released.

[Shazwazza]

@nzdev if you want to have a look, i've refactored in this rev: 36f4a5e Basically moving SkipTake to where Skip also was so the fluent API remains consistent. This is all working now and allows re-execution too. The only pretty ugly part is how the lazy execution of the TotalItemCount works, but to avoid breaking changes this is fine for now. Let me know what you think. I've also updated your test so probably easiest to just look at that one.

[nzdev]

Seems OK, though Execute() no longer actually executes the query.

[Shazwazza]

Execute() no longer actually executes the query

Yep that's true. That's also how it works in ExamineX as well since the execution is lazy. I don't think this is an issue but perhaps in the next netcore version we can re-think a bit of how this could/should work.

[nzdev]

Any news on when this will be merged to master?

[Shazwazza]

It's already merged and pending release https://github.com/Shazwazza/Examine/milestone/25?closed=1

was just waiting on some feedback from the pre-release. I'll get this out next week.

[nzdev]

@Shazwazza Thanks, sorry I hadn't seen that.

[nzdev]

The skiptake methods seem to not be present in v1.1.0

[Shazwazza]

🤦 🤦‍♂️ 🤦 🤦‍♂️ 🤦 🤦‍♂️ 🤦 🤦‍♂️

Sorry, i'll make another release, that is just stupid of me

[Shazwazza]

@nzdev there's a build here https://ci.appveyor.com/project/Shandem/examine/build/artifacts which is a 1.2.0 alpha. If you are able to test this release with your current setup for a bit, i'll get this one released by the end of the week or early next week.

[Shazwazza]

The nuget feed for that is here https://ci.appveyor.com/nuget/examine-f73l6qv0oqfh