Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Updated dependencies in the test project #293

Merged
merged 5 commits into from
Oct 25, 2022

Conversation

nikcio
Copy link
Contributor

@nikcio nikcio commented Oct 11, 2022

This updates the packages found in the test project to newer versions.

It includes:

  • Framework update to .Net 6.0
  • Microsoft.Extensions.Hosting 6.0.1
  • Microsoft.Extensions.Logging 6.0.0
  • Microsoft.Extensions.Logging.Console 6.0.0
  • Microsoft.NET.Test.Sdk 17.3.2
  • Moq 4.18.2
  • NUnit 3.13.3
  • Nunit3TestAdapter 4.2.1
  • System.Configuration.ConfigurationManager 6.0.1
  • Switch from Microsoft.Azure.Storage.Blob to Azure.Storage.Blob 12.13.1

@Shazwazza
Copy link
Owner

Hi, thanks for the effort here. As per previous msg, the branch for v3 is https://github.com/Shazwazza/Examine/tree/release/3.0. I'll go ahead and update the default branch for this repo to that branch to avoid more confusion. If you want to retarget the dependency changes to that branch, that would be great.

These changes in the test project are ok since we are not releasing this project as a public Nuget. However, please keep in mind we cannot introduce any breaking changes to Examine 3.x for the public consuming packages. If we want to build for both .NET Standard and .NET 6 then we need to multi-target the output.

@nikcio nikcio changed the base branch from dev to release/3.0 October 11, 2022 19:38
@nikcio
Copy link
Contributor Author

nikcio commented Oct 11, 2022

This has now been rebased to the correct branch and the target branch has been changed.

src/Examine.Test/Examine.Test.csproj Outdated Show resolved Hide resolved
src/Examine.Test/Examine.Test.csproj Show resolved Hide resolved
@Shazwazza Shazwazza merged commit 2c23a01 into Shazwazza:release/3.0 Oct 25, 2022
@Shazwazza Shazwazza added the hacktoberfest-accepted Part Hacktoberfest label Oct 28, 2022
@umbrabot
Copy link

Hi there @nikcio!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

As an alternative choice this year, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 18th, 2022, 09:00 AM UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few months, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Part Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants