-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix V4 compatibility with V3 API #347
Fix V4 compatibility with V3 API #347
Conversation
Support for efficient deep paging in lucene.net
test: Add .NET 7 target to tests
Added docs on Indexing events
Try to get build to run on PRs
CI - Add your build.yml change to the release branch 3.0
… back compatabiltiy issues for future releases.
@nzdev I tried this out today but ran into a breaking conflict. The existing subclasses won't load anymore and cause an error (for Umbraco it's
|
@andrewmckaskill Does that error only appear if the UseTaxonomyIndex option is on? If so, I think implementing a version of ConfigurationEnabledDirectoryFactory which implements the CreateTaxonomyDirectory() method is ok. See how ImageSharp v2/v3 was managed in Umbraco. If not, then we would need to move around the directory sync code as well as the directory code. |
@nzdev no it appears always. It's because they have directly extended the base class, which now has a new abstract method that has no implementation. One solution might be to make the method virtual instead of abstract, and to have the default implementation throw a NotImplemetedException. If the method is only used when Taxonomy is turned on then the default Umbraco implementation won't hit it. |
Done |
I think this looks good, will merge |
Builds on #346
Merges V3.x into V4.
Fixed compatibility issues with v3.