[fix] not rename screenshots if allure disabled

Shelex · Apr 14, 2020 · 7ff767a · 7ff767a
1 parent 0f81206
commit 7ff767a
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.4.1] - 2020-04-14
+
+### Fixed
+
+-   not rename screenshots if allure is disabled
+
 ## [1.4.0] - 2020-04-14
 
 ### Changed

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@shelex/cypress-allure-plugin",
-    "version": "1.4.0",
+    "version": "1.4.1",
     "description": "allure reporting plugin for cypress",
     "main": "reporter/index.js",
     "types": "reporter/index.d.ts",

diff --git a/writer.js b/writer.js
@@ -57,17 +57,22 @@ module.exports = function (on) {
         }
     });
     on('after:screenshot', (details) => {
-        const resultsDir = `allure-results`;
-        !fs.existsSync(resultsDir) && fs.mkdirSync(resultsDir);
-        const allurePath = path.join(resultsDir, `${uuid.v4()}-attachment.png`);
-        return new Promise((resolve, reject) => {
-            fs.copyFile(details.path, allurePath, (err) => {
-                if (err) {
-                    return reject(err);
-                }
-                resolve({ path: allurePath });
+        if (Cypress.env('allure') === true) {
+            const resultsDir = `allure-results`;
+            !fs.existsSync(resultsDir) && fs.mkdirSync(resultsDir);
+            const allurePath = path.join(
+                resultsDir,
+                `${uuid.v4()}-attachment.png`
+            );
+            return new Promise((resolve, reject) => {
+                fs.copyFile(details.path, allurePath, (err) => {
+                    if (err) {
+                        return reject(err);
+                    }
+                    resolve({ path: allurePath });
+                });
             });
-        });
+        }
     });
 };