fix: add guards for allure writer arrays handling, address #206

fix: attachments writing

reporter/index.js

@@ -78,20 +78,18 @@ const invokeResultsWriter = (allure, isGlobal) => {
             'writeAllureResults',
             {
                 results: allure.reporter.runtime.config,
-                files: allure.reporter.files,
+                files: allure.reporter.files || [],
                 mapping: allure.reporter.mochaIdToAllure,
                 clearSkipped: config.clearSkipped(),
                 isGlobal
             },
             { log: false }
-        )
-            // eslint-disable-next-line no-console
-            .catch((e) =>
-                logger.allure(
-                    `failed to execute task to write allure results: %O`,
-                    e
-                )
-            );
+        ).catch((e) =>
+            logger.allure(
+                `failed to execute task to write allure results: %O`,
+                e
+            )
+        );
         logger.allure(`writing allure results`);
     } catch (e) {
         // happens when cy.task could not be executed due to fired outside of it

test.sh

@@ -0,0 +1,5 @@
+npm run fixtures:clear
+npm run test:prepare:basic
+npm run test:prepare:statuses
+npm run test:prepare:cucumber
+npm test

writer/attachments.js

@@ -61,7 +61,8 @@ const attachScreenshotsAndVideo = (allureMapping, results, config) => {
             }
 
             const content =
-                fs.existsSync(testFilePath) && fs.readFileSync(testFilePath);
+                fs.existsSync(testFilePath) &&
+                fs.readFileSync(testFilePath, { encoding: 'utf-8' });
 
             if (!content) {
                 logger.writer('could not find file "%s"', testFilePath);

writer/results.js

@@ -13,6 +13,10 @@ const writeAttachmentFiles = ({ files, resultsDir, tests }) => {
         return;
     }
 
+    if (!tests || !tests.length) {
+        return;
+    }
+
     files.forEach((file) => {
         if (!fs.existsSync(file.path)) {
             return;
@@ -42,6 +46,10 @@ const writeAttachmentFiles = ({ files, resultsDir, tests }) => {
                 t.name === `"after all" hook for "${file.testName}"`
         );
 
+        if (!testsForAttachment || !testsForAttachment.length) {
+            return;
+        }
+
         testsForAttachment.forEach((test) => {
             logger.writer(
                 'attach "%s" to test "%s"',
@@ -62,20 +70,26 @@ const writeSuites = ({ groups, resultsDir, tests, clearSkipped }) => {
         return;
     }
 
-    groups.forEach((group) => {
-        if (!group.children || !group.children.length) {
-            return;
-        }
+    if (!tests || !tests.length) {
+        return;
+    }
+
+    const groupsWithTests = groups.filter(
+        (group) => group.children && group.children.length
+    );
 
+    groupsWithTests.forEach((group) => {
         if (clearSkipped) {
             logger.writer(
                 'clearing skipped tests enabled, removing tests from suite %s',
                 group.name
             );
+
             group.children = group.children.filter((testId) => {
                 const test = tests.find((test) => test.uuid === testId);
                 return test && test.status !== 'skipped';
             });
+
             if (!group.children.length) {
                 logger.writer('skip suite as it has no tests remained');
                 return;
@@ -89,13 +103,19 @@ const writeSuites = ({ groups, resultsDir, tests, clearSkipped }) => {
 
         // remove empty set up and tear down global hooks
         group.befores = group.befores
-            ? group.befores.filter((before) => before.steps.length)
+            ? group.befores.filter(
+                  (before) => before.steps && before.steps.length
+              )
             : [];
         group.afters = group.afters
-            ? group.afters.filter((after) => after.steps.length)
+            ? group.afters.filter((after) => after.steps && after.steps.length)
             : [];
 
-        fs.writeFileSync(groupResultPath, JSON.stringify(group));
+        try {
+            fs.writeFileSync(groupResultPath, JSON.stringify(group));
+        } catch (e) {
+            logger.writer(`failed to write suite file: ${e.message}`);
+        }
     });
 };
 

writer/useAfterSpec.js

@@ -14,11 +14,7 @@ const shouldUseAfterSpec = (config) => {
         return true;
     }
 
-    if (cypressVersion.above('6.2.0') && config.experimentalRunEvents) {
-        return true;
-    }
-
-    return false;
+    return cypressVersion.above('6.2.0') && config.experimentalRunEvents;
 };
 
 module.exports = { shouldUseAfterSpec };