Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignore_directories not taking effect #456

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Bo98
Copy link
Contributor

@Bo98 Bo98 commented Oct 27, 2023

Cache.new calls reinitialize which starts the PathScanner walk so ignored_directories should be set before doing that.

@casperisfine casperisfine merged commit 5404c13 into Shopify:main Oct 30, 2023
16 checks passed
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems October 30, 2023 08:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants