Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cart quantity input behaviour #724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spencercanner
Copy link
Contributor

@spencercanner spencercanner commented Sep 11, 2020

  • Prevent the line item from being updated if the quantity input is blurred but the quantity is not changes
  • Prevent the quantity from being incremented if the line item is still loading/updating an input change

To 🎩 :

  • Tab through a cart with line items
  • Verify that the quantity input/buttons do not appear disabled when tabbing out of the input if the value is not changed
  • Verify that the quantity updates when tabbing our of the input if the value is changed
  • Update the quantity input, then quickly tab to the increment button and click it be pressing enter/space
  • Verify that the increment click is not captured and the final quantity is equal to the value entered into the input
  • Sanity check that the increment/decrement buttons and input still work as expected
  • Safari - Mac
  • Chrome - Mac
  • Firefox - Mac
  • Edge - Mac
  • Legacy Edge - Windows
  • Edge - Windows
  • Chrome - Windows
  • Firefox - Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant