New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix focus outline cut off in product tile #729

Open

spencercanner wants to merge 1 commit into master from button-focus-cutoff

Contributor

spencercanner commented Sep 16, 2020 •

edited

Loading

Previously, the focus would be cut off for any elements that were near the edge of the iframe. This includes select elements, buttons, and isButton products
To address this, padding was added to the product container in the iframe giving its contents some space from the iframe boundary

To 🎩 :

Create a product buy button with product > isButton: true
Verify that the focus outline is shown around the entire product tile
Create a product buy button for a product with options
Verify that the focus outline is shown around the entire variant select element and the button

Browsers:


          fix focus outline cut off in product tile

f0b2c93

spencercanner changed the title ~~Fix focus outline cutoff in product tile~~ Fix focus outline cut off in product tile

spencercanner requested a review from melissaluu

September 16, 2020 16:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet