Raise error when progress is negative

Shopify · Aug 28, 2024 · d282ebf · d282ebf
1 parent e4804de
commit d282ebf
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/ruby/lib/ci/queue/redis/base.rb b/ruby/lib/ci/queue/redis/base.rb
@@ -133,8 +133,12 @@ def to_a
           end.flatten.reverse.map { |k| index.fetch(k) }
         end
 
+        ImplausibleProgress = Class.new(StandardError)
+
         def progress
-          total - size
+          result = total - size
+          raise ImplausibleProgress, "Progress cannot be negative (#{result} (#{total} - #{size}))" if result < 0
+          result
         end
 
         def wait_for_master(timeout: 30)