Fix flaky test record for skipped test #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a test for this? |
nikita8
force-pushed
the
nikita8/fix-flaky-tests
branch
from
037f006 to
6db9f3f
Compare
nikita8
commented
Oct 12, 2023
ruby/Gemfile
Outdated
| @@ -3,4 +3,4 @@ source 'https://rubygems.org' | |||
| # Specify your gem's dependencies in ci-queue.gemspec | |||
| gemspec | |||
|
|
|||
| gem 'activesupport' | |||
| gem 'activesupport', '~> 7.0.8' | |||
There was a problem hiding this comment.
Had to pin this back because CI is failing on latest 7.1.1
There was a problem hiding this comment.
We should fix it though, we already have apps on 7.1
There was a problem hiding this comment.
I pushed 5a7b8f0 which should fix the problem.
casperisfine
force-pushed
the
nikita8/fix-flaky-tests
branch
from
6db9f3f to
5a7b8f0
Compare
casperisfine
approved these changes
Oct 13, 2023
ChrisBr
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When test fails and are requeued it is treated as skipped for which the
record_successmethod is executed and hence these tests are added to the flaky list which is not desired. This PR fixes it by skipping recording of flaky tests for skipped tests.Tophat: The failing test in this build is no more in the flaky test list.