Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade graphql-request (ESM) #1440

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Upgrade graphql-request (ESM) #1440

merged 3 commits into from
Mar 2, 2023

Conversation

gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Feb 23, 2023

WHY are these changes introduced?

Related to https://github.com/Shopify/internal-cli-foundations/issues/502

Our current graphql-request version is a CommonJS dependency, so it's not loaded concurrently with the rest of ESM modules.

WHAT is this pull request doing?

Upgrades graphql-request to the latest version, which supports ESM.

How to test your changes?

shopify app dev

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/theme-developer-tools
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

@gonzaloriestra gonzaloriestra marked this pull request as ready for review February 23, 2023 18:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.79% (+0.16% 🔼)
4147/5697
🟡 Branches
69.58% (+0.19% 🔼)
1871/2689
🟡 Functions
70.28% (+0.02% 🔼)
1095/1558
🟡 Lines
74.1% (+0.18% 🔼)
3957/5340
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / options-prompt.ts
87.27% 86.05% 100% 87.04%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / ruby.ts
38.39% (-0.7% 🔻)
41.82%
34.38% (+1.04% 🔼)
41.58% (-0.84% 🔻)

Test suite run success

1057 tests passing in 534 suites.

Report generated by 🧪jest coverage report action from 065d78e

@gonzaloriestra gonzaloriestra requested review from a team, matteodepalo and amcaplan and removed request for a team February 23, 2023 18:17
@gonzaloriestra
Copy link
Contributor Author

We have finally decided to wait for the next stable release.

@gonzaloriestra
Copy link
Contributor Author

The stable release including with ESM support is here: https://github.com/jasonkuhrt/graphql-request/releases/tag/5.2.0

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Benchmark report

We detected a significant variation of startup time in the following commands.
Note that it might be related to external factors that influence the benchmarking.
If you believe that's the case, feel free to ignore the table below.

Status Command Baseline (avg) Current (avg) Diff
🔴 app env pull 1413.67 ms 1601.67 ms 13.3 %
🔴 app env show 1423.67 ms 1619.67 ms 13.77 %
🔴 app function schema 1486.33 ms 1648.67 ms 10.92 %
🔴 app info 1447.33 ms 1624.33 ms 12.23 %
🔴 app update-url 1403 ms 1544.67 ms 10.1 %
🔴 webhook trigger 1409.33 ms 1555.67 ms 10.38 %

@gonzaloriestra gonzaloriestra merged commit 66e388e into main Mar 2, 2023
@gonzaloriestra gonzaloriestra deleted the bump-graphql-request branch March 2, 2023 08:23
@shopify-shipit shopify-shipit bot temporarily deployed to nightly March 2, 2023 13:27 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production March 8, 2023 11:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants