-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade graphql-request (ESM) #1440
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1057 tests passing in 534 suites. Report generated by 🧪jest coverage report action from 065d78e |
We have finally decided to wait for the next stable release. |
The stable release including with ESM support is here: https://github.com/jasonkuhrt/graphql-request/releases/tag/5.2.0 |
cf2a59d
to
2e6c36f
Compare
2e6c36f
to
065d78e
Compare
Benchmark reportWe detected a significant variation of startup time in the following commands.
|
WHY are these changes introduced?
Related to https://github.com/Shopify/internal-cli-foundations/issues/502
Our current
graphql-request
version is a CommonJS dependency, so it's not loaded concurrently with the rest of ESM modules.WHAT is this pull request doing?
Upgrades
graphql-request
to the latest version, which supports ESM.How to test your changes?
shopify app dev
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.