Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Country/Region and Language selector] Support gradients ? #2384

Closed
ludoboludo opened this issue Mar 13, 2023 · 2 comments · Fixed by #2386
Closed

[Country/Region and Language selector] Support gradients ? #2384

ludoboludo opened this issue Mar 13, 2023 · 2 comments · Fixed by #2386
Assignees
Labels
Category: Bug Something isn't working

Comments

@ludoboludo
Copy link
Contributor

Describe the current behavior

Locales selectors do not support gradient background.

Describe the expected behavior

Should locales selectors support them ?

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 8
  • Chrome Version 108.0.5359.124
  • macOS Version 13.1

Possible solution

Tweak the colors for the localization form as well as the disclosure__list-wrapper.

Additional context/screenshots

Screenshot

cc: @melissaperreault

@ludoboludo ludoboludo added the Category: Bug Something isn't working label Mar 13, 2023
@ludoboludo ludoboludo self-assigned this Mar 13, 2023
@melissaperreault
Copy link
Contributor

UX details

Show we support gradients in the header locales selectors?

The short answer is, yes! (Includes drawer - to be tested)

Show we support gradients in the foofer locales selectors?

Short answer is, no.

Rationale
Since the gradient would remain, in general, predictable for the header because the height is more controlled, I don't believe we need the fallback solid color applied here. Supporting the gradient smoothly will help polish the details of an already cluttered listing. Of course this will rely solely on merchants extra care and attention to hand pick a good high contrast foreground color to stand out well. It's already the case to set their menu items, icons, and now selector labels for success to remain legible.

@ludoboludo
Copy link
Contributor Author

PR created to fix it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants