-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Header locales] Support gradients #2386
Conversation
We recommend to not support gradient to align with the filter dropdown experience. Gradients don't blend well in a short height form. This is in favor of legibility/functionality. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting some minor inconsistencies between the Language/currency selectors and the dropdown in the menu. The bottom borders seem to have a different colour, and the menu dropdown background is transparent, while the language/currency picker isn't. Do we want these to match?
borders.mp4
@metamoni ill take a look. If you share some screenshots of what you're seeing in those cases it would help 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Works well!
[Header locales] Support gradients (Shopify#2386)
* shopify/main: Gift cards/add recipient (Shopify#2412) Update 1 translation file (Shopify#2453) [Slideshow] Add ambient movement to background (Shopify#2383) Wrap calls to search results ind collection counts in paginate to reduce additional requests (Shopify#2421) [Header] Add app block in the header section (Shopify#2238) [Image with Text] Add ambient movement to image (Shopify#2385) Update 1 translation file (Shopify#2450) [Blog post section] Fix slides size on mobile (Shopify#2368) Duplicated scrollbar in drawer menu (Shopify#2400) [Header locales] Support gradients (Shopify#2386) [Image banner] Add ambient movement to background (Shopify#2342)
* support gradien in header for locales selector * Remove gradient from local dropdowns in header
PR Summary:
This PR is adding gradient support to the country/region selector and language selector, in the header specifically.
Why are these changes introduced?
Fixes #2384
What approach did you take?
Added the
.gradient
class where necessary and set the background totransparent
on thelocalization-form__select
.Other considerations
Decision log
Visual impact on existing themes
No impact as the feature it's touching hasn't been released yet.
Testing steps/scenarios
Demo links
Checklist