Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed max price display on filter drawer #1512

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Fixed max price display on filter drawer #1512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions snippets/facets.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@
{{ filter.label | escape }}
</button>

{%- assign max_price_amount = filter.range_max | money | strip_html | escape -%}
<p class="mobile-facets__info">{{ "products.facets.max_price" | t: price: max_price_amount }}</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the assign should then be outside of the conditional so it's declared only once. 🤔
THoughts ?

Copy link
Contributor Author

@tyleralsbury tyleralsbury Mar 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about adding it higher up, but it really disconnects it from where it's being used. So my thought was that duplicating the code was actually clearer since it was able to be used right where it was declared. Especially since it's a pretty simple one-liner, I felt okay with duplicating it.


<price-range class="facets__price">
Expand Down