Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
In this PR we're removing the lower opacity we have on some text element throughout the theme. This is done to make it easier for us to keep our theme accessible with a contrast ratio that passes the AA standards.
There are a few places that this is affecting and we will need to work together with Designers to figure out where it's ok and where we might want to do something to preserve the hierarchy we had by using different opacity on text elements.
Elements impacted:
.color-background-1,
.color-background-2,
.color-inverse,
.color-accent-1,
.color-accent-2
.customer .field label ( labels for inputs on the customer page and for field__label which is used in many places like: facet filter, main product, main article, contact form, email signup, footer, header, main search, etc )
.copyright__content a ( this is for the menu items in the footer and the copyright: screenshot )
Why are these changes introduced?
Fixes #1521
After noticing a few issues with color contrast between text and the background, the idea of removing the text opacity was brought up. This is to look into our initial approach and decide whether it's something sustainable and guarantee our merchant to have the most accessible storefront possible even though we do not have control of the colors chosen.
What approach did you take?
I looked at all the CSS declarations using
.75
opacity and removed it.Other considerations
There are other styling declarations across the theme with a different opacity that can also be looked into.
I think there is also an opportunity to remove some of the styling we had for colors for the selectors mentioned above.
Testing steps/scenarios
Demo links
Checklist