-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich text improvements #1635
Merged
Merged
Rich text improvements #1635
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
46d2d75
Rich text improvements
f5c0080
Add help text for desktop content position
9199a72
Remove extra caption block class
310a708
Update 15 translation files
translation-platform[bot] ba3f37b
Update 2 translation files
translation-platform[bot] 49985b8
Change to inline button blocks
a8f0861
Update 3 translation files
translation-platform[bot] 6ed7dd9
Update block limits and strings
da9c9df
Clean up CSS and add unique classes for buttons
95a4f28
CSS updates for multiple buttons
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to your PR but because I noticed it here, I'll leave it as a reminder for us to review this later and create an issue for this.
The setting is called
Desktop content position
and applies to "tablet and above" (>750px
). It looks we're consistently doing that in many other sections like Image with Text, Image Banner and others. Sounds like this is the intended behaviour.But I just noticed that on the Product page, the
Desktop layout
applies to >750px
and theDesktop media size
applies to >990px
. It uses the sameautomatically optimized for mobile
description that is mentioned in the setting you just added, so I'm wondering if there are more occurrences of this inconsistency across the theme.