Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination to main collection list #1745

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Add pagination to main collection list #1745

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca04dfb
add pagination to main collection list
ludoboludo May 26, 2022
706726d
calculate the amount to paginate by dynamically
ludoboludo May 26, 2022
5002d43
change number to paginate by
ludoboludo May 26, 2022
ab5161a
remove test logging
ludoboludo May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions sections/main-list-collections.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,23 @@
if section.settings.sort == 'products_high' or section.settings.sort == 'date_reversed' or section.settings.sort == 'alphabetical_reversed'
assign collections = collections | reverse
endif

assign moduloResult = 28 | modulo: section.settings.columns_desktop
assign paginate_by = 30
if moduloResult == 0
assign paginate_by = 28
endif
LucasLacerdaUX marked this conversation as resolved.
Show resolved Hide resolved
-%}
<ul class="collection-list grid grid--{{ section.settings.columns_desktop }}-col-desktop grid--{{ section.settings.columns_mobile }}-col-tablet-down" role="list">
{%- for collection in collections -%}
<li class="collection-list__item grid__item">
{% render 'card-collection', card_collection: collection, media_aspect_ratio: section.settings.image_ratio, columns: 3 %}
</li>
{%- endfor -%}
</ul>
{%- paginate collections by paginate_by -%}
<ul class="collection-list grid grid--{{ section.settings.columns_desktop }}-col-desktop grid--{{ section.settings.columns_mobile }}-col-tablet-down" role="list">
{%- for collection in collections -%}
<li class="collection-list__item grid__item">
{% render 'card-collection', card_collection: collection, media_aspect_ratio: section.settings.image_ratio, columns: 3 %}
</li>
{%- endfor -%}
</ul>
{% render 'pagination', paginate: paginate %}
{%- endpaginate -%}
</div>
{% schema %}
{
Expand Down