Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mark element not getting the right color #2286

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Conversation

ludoboludo
Copy link
Contributor

Fix mark element getting a color from the browser which end up overwriting our default text color.

@kmeleta kmeleta self-requested a review February 3, 2023 20:01
Copy link
Contributor

@melissaperreault melissaperreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

kmeleta
kmeleta previously approved these changes Feb 3, 2023
Copy link
Contributor

@kmeleta kmeleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well commit the missing space, but fix looks good.

Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>
@ludoboludo ludoboludo merged commit 4401944 into main Feb 3, 2023
@ludoboludo ludoboludo deleted the fix-search-text-color branch February 3, 2023 20:10
chris-kreidl added a commit to uniorusa/unior-usa-b2b that referenced this pull request Feb 6, 2023
Fix mark element not getting the right color (Shopify#2286)
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
* Fix mark element not getting the right color

* Update assets/component-predictive-search.css

Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>

---------

Co-authored-by: Andrew Etchen <andrew.etchen@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants