Add intersection observer #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metamoni
force-pushed
the
add-intersection-observer
branch
2 times, most recently
from
334c0a1
to
bdc3d37
Compare
metamoni
changed the title
metamoni
force-pushed
the
add-intersection-observer
branch
from
bdc3d37
to
537c5bc
Compare
metamoni
force-pushed
the
animate-on-scroll
branch
2 times, most recently
from
842f4ae
to
606261a
Compare
metamoni
force-pushed
the
add-intersection-observer
branch
from
537c5bc
to
103260b
Compare
metamoni
requested review from
stufreen,
kjellr and
LucasLacerdaUX
and removed request for
kjellr and
stufreen
stufreen
reviewed
Mar 1, 2023
metamoni
force-pushed
the
add-intersection-observer
branch
3 times, most recently
from
070b1ac
to
1f37a8a
Compare
metamoni
force-pushed
the
animate-on-scroll
branch
from
606261a
to
f309b91
Compare
metamoni
force-pushed
the
add-intersection-observer
branch
2 times, most recently
from
e3e17e6
to
bb4dca0
Compare
stufreen
reviewed
Mar 2, 2023
metamoni
force-pushed
the
add-intersection-observer
branch
3 times, most recently
from
d7cf582
to
2ebbebd
Compare
metamoni
changed the base branch from
animate-on-scroll
to
reveal-on-scroll-animations
stufreen
reviewed
Mar 3, 2023
metamoni
changed the title
metamoni
force-pushed
the
add-intersection-observer
branch
from
2ebbebd
to
3570762
Compare
metamoni
changed the base branch from
reveal-on-scroll-animations
to
animate-on-scroll
metamoni
force-pushed
the
add-intersection-observer
branch
from
0397227
to
5674f85
Compare
kjellr
reviewed
Mar 6, 2023
stufreen
approved these changes
Mar 6, 2023
Base automatically changed from
animate-on-scroll
to
reveal-on-scroll-animations
March 7, 2023 10:28
metamoni
force-pushed
the
reveal-on-scroll-animations
branch
from
0e6d095
to
cfefdd7
Compare
metamoni
force-pushed
the
add-intersection-observer
branch
from
5674f85
to
b73d668
Compare
metamoni
force-pushed
the
add-intersection-observer
branch
from
b73d668
to
6c277d4
Compare
15 tasks
LucasLacerdaUX
approved these changes
Mar 8, 2023
metamoni
added a commit
that referenced
this pull request
Mar 10, 2023
* add scroll animation observer for section
metamoni
added a commit
that referenced
this pull request
Mar 13, 2023
* add scroll animation observer for section
metamoni
added a commit
that referenced
this pull request
Mar 15, 2023
* add scroll animation observer for section
metamoni
added a commit
that referenced
this pull request
Mar 23, 2023
* add scroll animation observer for section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This PR adds an
animationsscript with an intersection observer that will watch elements with a class ofscroll-animation__triggerand add ascroll-animation__trigger--activeclass as they scroll them into view.Why are these changes introduced?
Fixes #2316
What approach did you take?
animationsscript from this prototypeVisual impact on existing themes
None. This code won't do anything until we add the CSS and the trigger class to different elements we want to animate.
Testing steps/scenarios
animationsscript is loaded for the following pages: Homepage, Default product, Collections, Collections List, BlogsDemo links
Checklist