Animate contact form on scroll #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
requested review from
stufreen,
metamoni,
melissaperreault and
ludoboludo
metamoni
approved these changes
Apr 11, 2023
ludoboludo
reviewed
Apr 11, 2023
Co-authored-by: Ludo <ludo.segura@shopify.com>
ludoboludo
reviewed
Apr 11, 2023
Co-authored-by: Ludo <ludo.segura@shopify.com>
ludoboludo
approved these changes
Apr 11, 2023
metamoni
approved these changes
Apr 13, 2023
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* Animate contact form on scroll. * Update sections/contact-form.liquid Co-authored-by: Ludo <ludo.segura@shopify.com> * Update sections/contact-form.liquid Co-authored-by: Ludo <ludo.segura@shopify.com> --------- Co-authored-by: Ludo <ludo.segura@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Adds animate-on-scroll classes to the contact form section.
Why are these changes introduced?
Fixes #2509
Visual impact on existing themes
Will animate the contact form section when Reveal sections on scroll is enabled.
11-57-g3ogs-p931i.mp4
Testing steps/scenarios
Demo links
Checklist