Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate the footer section #2521

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Animate the footer section #2521

merged 1 commit into from
Apr 14, 2023

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Apr 13, 2023

PR Summary:

Adds cascading fade in on scroll animation to Footer section.

Why are these changes introduced?

Closes #2422.

What approach did you take?

Replicated animations from the #2141

Visual impact on existing themes

Will animate the Footer section on scroll, when Reveal sections on scroll is enabled.

13-51-npfy5-p8cmj.mp4

Testing steps/scenarios

  • Ensure "Reveal sections on scroll" is checked within Theme Settings > Animations.
  • Scroll down to the footer, watch it animate in.
  • Add/remove blocks and adjust settings. Ensure things continue to animate in smoothly.

Demo links

Checklist

@kjellr kjellr added Category: Enhancement New feature or request motion labels Apr 13, 2023
@kjellr kjellr self-assigned this Apr 13, 2023
{% if settings.animations_reveal_on_scroll %}
data-cascade
{% endif %}
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem to works as expected in my tests 👍

The one thing I wonder though is if it should be applied to the footer 🤔

I personally don't feel like it adds much, and just like the header section, I prefer it not to animate. I can see how it could be odd that some do and some don't but since it's something that comes up on all pages, I prefer the impression that it's the content in the "middle" that needs to be loaded in.

Curious to hear yours and other's thoughts on it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, @melissaperreault raised this earlier too. I went back and forth on it myself, but do I think it makes sense to animate the footer.

The detail that convinced me most is the columned content: We're animating columned content in sequentially everywhere else it appears on the storefront, so it feels like a letdown if you get to the bottom and all of a sudden you get some columned content that does not animate anymore. Although the footer can be a little more utilitarian than the rest of the page, I think animating it helps maintain the continuity of the animation.

@kjellr kjellr merged commit cc01f55 into main Apr 14, 2023
@kjellr kjellr deleted the animate-footer-section-on-scroll branch April 14, 2023 12:52
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Footer] Add cascading fade in on scroll animation
3 participants