-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Social media settings defaults to remove Shopify links #2830
Merged
lougoncharenko
merged 1 commit into
main
from
update-social-media-settings-defaults-to-remove-shopify-links
Aug 9, 2023
Merged
Update Social media settings defaults to remove Shopify links #2830
lougoncharenko
merged 1 commit into
main
from
update-social-media-settings-defaults-to-remove-shopify-links
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lougoncharenko
requested review from
KaichenWang,
sofiamatulis,
kmeleta and
katycobb
July 12, 2023 14:09
Looks as expected in the editor! |
kmeleta
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with using the existing translation key as is 👍
ludoboludo
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
lougoncharenko
deleted the
update-social-media-settings-defaults-to-remove-shopify-links
branch
August 9, 2023 20:10
TimmersThomas
added a commit
to TimmersThomas/shopify-template-houseofchocolate
that referenced
this pull request
Aug 13, 2023
* upstream/main: (205 commits) Fix for small screens with large fonts don't fit all content (Shopify#2946) Adjust quantity rules margin (Shopify#2948) Update Social media settings defaults to remove Shopify links (Shopify#2830) added json to barcode to pass gtin as a json string (Shopify#2804) Fixed extra margin spacing in collage section when header is empty (Shopify#2770) Track state of mouseenter event (Shopify#2934) Fix misalignment of total items in quick order list (Shopify#2923) Hide vol pricing and qty rules when variant is unavailable (Shopify#2889) Fix font family for quick order list (Shopify#2888) v11.0.0 version bump and release notes (Shopify#2916) Revert "v11.0.0 version bump and release notes (Shopify#2906)" (Shopify#2915) Update quantity-popover.css v11.0.0 version bump and release notes (Shopify#2906) Fix social list styles loading (Shopify#2900) Fix an error (Shopify#2903) Fix hardcoded info color (Shopify#2893) Fix error misalignment for Quick order list (Shopify#2887) Replace generic section name with section ID. (Shopify#2884) Fix cart drawer for variant list and tablet spacing (Shopify#2880) Add missing shadow styles to inputs in Quick Order List (Shopify#2879) ...
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
The social media section in theme settings using Shopify links as placeholders
Why are these changes introduced?
Fixes #2722
What approach did you take?
Replaced "info": with "placeholder": in the settings_schema file and kept the same translated text being used for info.
Other considerations
This is what I currently have (under current) and the possibility is another consideration we could have. The second option will have to send the files for translations instead of using a translated text we already have. I am open to doing it this way as well.
current:
"placeholder": "t:settings_schema.social-media.settings.social_vimeo_link.info"
Possibility:
"placeholder": "t:settings_schema.social-media.settings.social_vimeo_link.placeholder"
Visual impact on existing themes
N/A
Testing steps/scenarios
Demo links
Checklist